Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookletcreator 2.1.0 #170920

Merged
merged 1 commit into from
Apr 9, 2024
Merged

bookletcreator 2.1.0 #170920

merged 1 commit into from
Apr 9, 2024

Conversation

unitof
Copy link
Contributor

@unitof unitof commented Apr 9, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


Fails audit because this version was not added to appcast. Likely a mistake—I just notified the developer today. It is on the changelog and is the current version downloaded from the homepage.

@daeho-ro
Copy link
Member

daeho-ro commented Apr 9, 2024

It supports arm now but the minimum version of macos is Mojave, and the livecheck url is not updated for the most recent version.

@unitof unitof force-pushed the bump-bookletcreator branch from b2decf0 to 8bd19a6 Compare April 9, 2024 21:25
@unitof
Copy link
Contributor Author

unitof commented Apr 9, 2024

Developer confirmed with me via email that Sparkle is no longer used after 2.0.5. Livecheck updated to alternative method.

Developer confirmed with me via email that Sparkle is not used after v2.0.5
@unitof unitof force-pushed the bump-bookletcreator branch from e91c648 to 8df9990 Compare April 9, 2024 22:29
Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @unitof

@bevanjkay bevanjkay merged commit 71f6d81 into Homebrew:master Apr 9, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants