Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-menu 1.3 (new cask) #170911

Closed
wants to merge 1 commit into from
Closed

sc-menu 1.3 (new cask) #170911

wants to merge 1 commit into from

Conversation

joewiz
Copy link
Contributor

@joewiz joewiz commented Apr 8, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • [-] brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Note: This is a new application (released last month) and so doesn't yet meet the "notability" threshold as identified in the brew audit --cask --new check, but I think that with the aid of being available in Homebrew, it will grow in prominence fairly quickly. The tool is incredibly helpful for users of Smartcards (also known as PIV or CAC cards). It's already gotten some traction in the Mac Admins Slack workspace's #smartcards channel, as well as among colleagues in my organization that I've shared it with. I think this will enjoy popularity from users in government and industries that use smartcards.

Would there be a way to consider it?

@krehel krehel added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label Apr 9, 2024
@krehel
Copy link
Member

krehel commented Apr 9, 2024

Hey @joewiz - thanks for the background on this software. It is unfortunate the software doesn't meet minimum requirements, but I think the explanation makes sense along with the utility of this tool. Seems reasonable.

I don't have any issue exempting this from the checks. Other Homebrew maintainers can also chime in.

@bevanjkay
Copy link
Member

but I think that with the aid of being available in Homebrew, it will grow in prominence fairly quickly.

This can be somewhat of a chicken and egg problem. But I think it's worth noting that Homebrew does not consider itself to be a discovery service, so I don't think it is fair to expect that adding the software here would help it gain any popularity.

I think we should wait on this for a little bit and see if it gains a little more traction. Perhaps see if some more people can star the repo?

@krehel krehel changed the title Add SC Menu.app v1.3 sc-menu 1.3 (new cask) Apr 9, 2024
@p-linnane
Copy link
Member

I think this is something that would be best hosted in a personal tap. It seems too niche for inclusion here.

@SMillerDev SMillerDev closed this Apr 9, 2024
@joewiz
Copy link
Contributor Author

joewiz commented Apr 9, 2024

Thanks for everyone's feedback. May I resubmit the PR once the app meets the notability threshold?

@p-linnane
Copy link
Member

Thanks for everyone's feedback. May I resubmit the PR once the app meets the notability threshold?

Yep. That's totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants