Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mpv to stolendata-mpv #170887

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Rename mpv to stolendata-mpv #170887

merged 1 commit into from
Apr 8, 2024

Conversation

vitorgalvao
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Closes #86226. This cask didn’t follow the naming rules and the issue for it is almost four years old. Seeing as cask_renames.json is now a thing (hey, exactly one year ago!) the transition should be smoother.

One important consideration is that the username stolendata might create some confusion or scares.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks @vitorgalvao!

@p-linnane p-linnane merged commit 70e2481 into Homebrew:master Apr 8, 2024
15 checks passed
@vitorgalvao vitorgalvao deleted the mpv-rename branch April 8, 2024 19:36
@jedahan
Copy link
Contributor

jedahan commented Apr 8, 2024

yeah i got concerned, and had to dig a bit to find this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with mpv
5 participants