Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchdesigner 2023.11600 #170803

Merged
merged 3 commits into from
Apr 9, 2024
Merged

touchdesigner 2023.11600 #170803

merged 3 commits into from
Apr 9, 2024

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Apr 6, 2024

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Apr 6, 2024
@daeho-ro
Copy link
Member Author

daeho-ro commented Apr 6, 2024

Livecheck url is added.

Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Apr 9, 2024
@krehel krehel requested a review from samford April 9, 2024 00:22

url "https://download.derivative.ca/TouchDesigner.#{version}.#{arch}.dmg"
name "Derivative TouchDesigner"
desc "Tool for creating dynamic digital art"
homepage "https://derivative.ca/"

livecheck do
skip "No reliable way to get version info"
url "https://docs.derivative.ca/Release_Notes"
regex(/href=["'].*?["']>build\s?(\d+(?:\.\d+)+)\s?download\s?</i)
Copy link
Member

@samford samford Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regex(/href=["'].*?["']>build\s?(\d+(?:\.\d+)+)\s?download\s?</i)
regex(/href=["'].*?["']>build\s?(\d+(?:\.\d+)+)\s?download\s?</i)

Looking back at archive.org snapshots of the Release Notes page, the text around the download link has varied over the years. For example:

  • Current Official Build 2023.11600 Download - Mar 04 2024 - Release Notes
  • Current Build 2020.24520 - Jump to Release Notes - Download Here
  • Current Build 2021.13610 - May 12 2021 - Jump to this build's Release Notes - Download Here
  • The latest Official build is 2019.14650 - Download

Outside of the oldest "build is 2019.14650" format, simply matching the "Build 2023.11600" format would cover most of those variations (not when the version used to be in a b tag) and may be less likely to break over time. I'll push a commit to update this in a moment.

@krehel krehel merged commit 02e0255 into Homebrew:master Apr 9, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` outdated stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants