-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viable 1b12 (new cask) #170763
viable 1b12 (new cask) #170763
Conversation
Livecheck regex is not ideal as this appears to be a beta and contains a letter, hopefully this stabilizes in the future to a proper version number. Right now it's a bit generous, but anchored between text so hopefully avoids false positives |
Signed-off-by: Justin Krehel <[email protected]>
Whoops, sorry about that! I noticed you pushed a commit @krehel, any other items I should address? Also, regarding the zap stanza, did you just do a filesystem search with Anything else you'd like addressed before ready for review/merge? Thanks again!! |
Thanks so much for your first contribution, @mariolopjr! For future reference, we have some instructions on how to add zap stanzas! :) Without contributions like yours, it'd be impossible to keep our project going. 👍 |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.I tried running
brew audit
andbrew style
but both did not like paths and this is a new cask so not sure how to run it correctly.