Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viable 1b12 (new cask) #170763

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Conversation

mariolopjr
Copy link
Contributor

@mariolopjr mariolopjr commented Apr 6, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

I tried running brew audit and brew style but both did not like paths and this is a new cask so not sure how to run it correctly.

@krehel
Copy link
Member

krehel commented Apr 6, 2024

Livecheck regex is not ideal as this appears to be a beta and contains a letter, hopefully this stabilizes in the future to a proper version number. Right now it's a bit generous, but anchored between text so hopefully avoids false positives

Signed-off-by: Justin Krehel <[email protected]>
@krehel krehel force-pushed the add-viable-cask branch from 7862951 to d585045 Compare April 6, 2024 17:38
@mariolopjr
Copy link
Contributor Author

Livecheck regex is not ideal as this appears to be a beta and contains a letter, hopefully this stabilizes in the future to a proper version number. Right now it's a bit generous, but anchored between text so hopefully avoids false positives

Whoops, sorry about that! I noticed you pushed a commit @krehel, any other items I should address? Also, regarding the zap stanza, did you just do a filesystem search with Viable? I noticed the file in the preferences, but didn't realize the other files created. Just want to be sure when I contribute future packages I don't miss other created files.

Anything else you'd like addressed before ready for review/merge? Thanks again!!

@razvanazamfirei razvanazamfirei changed the title Add Viable 1b12 (new cask) viable 1b12 (new cask) Apr 7, 2024
@razvanazamfirei
Copy link
Contributor

Thanks so much for your first contribution, @mariolopjr! For future reference, we have some instructions on how to add zap stanzas! :)

Without contributions like yours, it'd be impossible to keep our project going. 👍

@razvanazamfirei razvanazamfirei merged commit 79a2283 into Homebrew:master Apr 7, 2024
10 checks passed
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants