Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hhkb-studio 1.0.4 (new cask) #170731

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

yhirano
Copy link
Contributor

@yhirano yhirano commented Apr 5, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

See: About naming this cask.
#170731 (comment)

@yhirano yhirano force-pushed the hhkb-studio-keymap-tool branch from 6d11903 to 1b34117 Compare April 5, 2024 13:36
@yhirano yhirano changed the title hhkb-studio-keymap-tool 1.0.4 hhkb-studio-keymap-tool 1.0.4 (new cask) Apr 5, 2024
@bevanjkay
Copy link
Member

Thank you for your contribution to homebrew-cask, @yhirano
I believe this application already exists here - https://github.com/Homebrew/homebrew-cask/blob/master/Casks/h/hhkb.rb

@razvanazamfirei
Copy link
Contributor

I think they're technically different. Our current cask is Happy Hacking Keyboard Keymap Tool and this is Happy Hacking Keyboard Studio Keymap Tool. I'm not sure what the best way to disambiguate the two. Perhaps calling this cask hhkb-studio?

@yhirano
Copy link
Contributor Author

yhirano commented Apr 6, 2024

Thank you for the review of this pull request!

As pointed out, this pull request is a cask for Happy Hacking Keyboard **Studio** Keymap Tool, which is a different tool from Happy Hacking Keyboard Keymap Tool(hhkb).
This cask is a tool for customize Happy Hacking Keyboard Keyboard Studio, and hhkb is a tool for customize Happy Hacking Keyboard.

I'm not sure what the best way to disambiguate the two. Perhaps calling this cask hhkb-studio?

hhkb-studio-keymap-tool is named by the generate_cask_token script, but I would also like to rename it to hhkb-studio if possible.
If renaming is allowed, I will update this cask.

@bevanjkay
Copy link
Member

I think keep this consistent with the existing cask makes sense.

@yhirano yhirano force-pushed the hhkb-studio-keymap-tool branch from 8d68f43 to c4eb081 Compare April 10, 2024 01:00
@yhirano yhirano changed the title hhkb-studio-keymap-tool 1.0.4 (new cask) hhkb-studio 1.0.4 (new cask) Apr 10, 2024
@yhirano
Copy link
Contributor Author

yhirano commented Apr 10, 2024

Renamed hhkb-studio-keymap-tool to hhkb-studio.

@p-linnane p-linnane merged commit ce08f3b into Homebrew:master Apr 10, 2024
13 checks passed
@yhirano yhirano deleted the hhkb-studio-keymap-tool branch April 10, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants