Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aladin 12.060 fixed #170703

Merged
merged 5 commits into from
Apr 11, 2024
Merged

aladin 12.060 fixed #170703

merged 5 commits into from
Apr 11, 2024

Conversation

niu541412
Copy link
Contributor

The URL in the previous cask is actually an outdated version which is ~11.0.
The latest version 12 is provided by specific amd64 and arm architecture.
Furthermore, the dmg packages are distributed with Java runtime in it.
It also contains an installer in the dmg tarball.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The livecheck also doesn't seem to be functional, so will need some further investigation there.

@krehel
Copy link
Member

krehel commented Apr 5, 2024

The livecheck also doesn't seem to be functional, so will need some further investigation there.

This may be CI as I am able to use it fine locally. Does it work for you locally @bevanjkay?

Edit: Last couple PR's needed ci-skip-livecheck - #163680, #147236

@bevanjkay
Copy link
Member

/rebase

@niu541412 niu541412 requested a review from bevanjkay April 8, 2024 05:05
@krehel krehel added the ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment label Apr 8, 2024
@miccal miccal merged commit f37b94c into Homebrew:master Apr 11, 2024
13 checks passed
@niu541412 niu541412 deleted the aladin_12 branch April 12, 2024 02:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-skip-livecheck Skip livecheck checks on CI. Use only for working checks that exclusively fail in the CI environment outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants