samsung-magician 8.1.0.800

[ACasset]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused.
• Checked the cask is submitted to the correct repo.
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

Hello,

As this is my first contribution, there probably are improvements I need to make, don't hesitate to tell me!

I tried to follow the https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request guide as best I could, but the brew test <CHANGED_FORMULA|CHANGED_CASK> command on step 5 returned an Error: No available formula with the name "samsung-magician", and I could not find a modifier for casks. I guess it's only used for formulae.

Important notice : the pkg install process spawns 3 popups, I don't know if I should automate the responses, especially the first one given the question (relative to the user location). And I don't know if the pkg choices stanza would work, given that I did not find the related strings with the installer -showChoicesXML command.

For the cask :

• I don't know if the description is short enough, I considered removing the part between ()
• For auto_updates, the software does provide an Updates menu, but I don't know yet if it updates itself or if it opens a web page, I'll check when they release a new version and correct if needed.
• I tried the quit way before signal, with no success, and I tried TERM before QUIT for com.samsung.magician.8.0.
• I voluntarily excluded a package (com.samsung.magician.softwarepkg) from pkgutil as it generated errors during uninstall.

Thanks!

[bevanjkay]

Hi @ACasset, thanks for your contribution.
There was already a submission for this cask that had some issues - #168388

[ACasset]

Hi @ACasset, thanks for your contribution. There was already a submission for this cask that had some issues - #168388

Oh sorry, I checked the link but it focuses on the issues and I did not see the closed PR on the left.

[bevanjkay]

Unfortunately I think this will suffer from the same. The pkg cannot be installed headlessly and requires user intervention.

[ACasset]

Unfortunately I think this will suffer from the same. The pkg cannot be installed headlessly and requires user intervention.

Yes, after reading #168388, I figured as much.

Thank you for your time!