piezo 1.9.1

[pthariensflame]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

---

Only on 14+ (should be only on 14.4+ but we don't have anything finer-grained AFAIK).

[daeho-ro]

It seems that the system version in the livecheck url indicates the mac os version in numbers. Most recent sonoma version is 14.4.0 and so it should be separated. The version parameter do nothing I guess. The later livecheck should be deleted if you apply this change.

Suggested change

	on_ventura :or_older do
	version "1.8.2"
	end
	on_sonoma :or_newer do
	version "1.9.0"
	end
	on_ventura :or_older do
	version "1.8.2"
	livecheck do
	url "https://rogueamoeba.net/ping/versionCheck.cgi?format=sparkle&system=1231&bundleid=com.rogueamoeba.Piezo&platform=osx"
	strategy :sparkle
	end
	end
	on_sonoma :or_newer do
	version "1.9.0"
	livecheck do
	url "https://rogueamoeba.net/ping/versionCheck.cgi?format=sparkle&system=1440&bundleid=com.rogueamoeba.Piezo&platform=osx"
	strategy :sparkle
	end
	end

[daeho-ro]

Btw, sonoma with 14.3.1 will get the wrong version, so maybe it looks better to remain it until next major version update?

[pthariensflame]

Yeah, I just wasn't sure if someone would come here and know an incantation to actually pick out 14.4+ within a cask.

[p-linnane]

We don't support scoping to minor/patch versions of macOS. It's presumed that users are on the latest minor/patch version.

[pthariensflame]

@p-linnane Is there a way to obtain that number, so it can be slotted into the livecheck URL?

[p-linnane]

Not reliably to my knowledge. @Bo98 any ideas if there's a clever way to handle this?

[Bo98]

MacOS.full_version exists but it is maybe not what you want. We don't store information on the latest patch release per major OS.

[bevanjkay]

The version that is in the livecheck won't affect what version is installed anyway. The new version will be installed on any machine running Sonoma.

[daeho-ro]

What about in this way with the custom module?

module Utils
  def self.reduced_version
    MacOS.full_version.to_s.delete(".")[0, 3]
  end

  def self.piezo_version
    if reduced_version < "144"
      "1.8.2"
    else
      "1.9.0"
    end
  end
end

cask "piezo" do
  version Utils.piezo_version.to_s
  sha256 :no_check

  url "https://rogueamoeba.com/piezo/download/Piezo.zip"
  name "Piezo"
  desc "Audio recording application"
  homepage "https://rogueamoeba.com/piezo/"

  livecheck do
    url "https://rogueamoeba.net/ping/versionCheck.cgi?format=sparkle&system=#{Utils.reduced_version}&bundleid=com.rogueamoeba.Piezo&platform=osx"
    strategy :sparkle
  end

 ...

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[pthariensflame]

I'll come back to this; there are now more apps from Rogue Amoeba that have this exact same issue.

[samford]

I've updated this to use the setup that I recently used in airfoil and audio-hijack, while also updating the cask for 1.9.1 (and rebasing the branch). This should bring us closer to where we want to be but there may still be something to be said for discussing this approach (in case there's still room for improvement).

I believe the open questions are:

• Should we use MacOS.full_version.to_s.delete(".") instead of hardcoding the system value (in the livecheck block url)? This will vary based on the execution environment, so there's a trade-off between maintainability (having to periodically update the system value) and predictability. I'm not sure that anyone will remember to update the system value over time (which will quietly cause the check to stop returning new versions), so a dynamic approach may make more sense.
• Is there any benefit to having the version query string parameter in the livecheck block url? The value we're using doesn't seem to correspond with the value the application uses when fetching the Sparkle feed. We can experiment with omitting the version value and if that continues to give us the newest appropriate version over time, then that may be fine.

For what it's worth, I've opted to use 1366 as the system value for the on_ventura :or_older block, as using the highest macOS version in that range will hopefully keep that check working for longer. If we use the lowest version in the range, then the check may quietly stop returning newer versions at an earlier point if/when upstream increases the macOS requirement for the older variant in the future. For example, if we used 11 and they only dropped Big Sur support, then the check would always return an older version even if newer versions appear.