samsung-magician 8.0.0.900 (new cask)

[breckwagner]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused.
• Checked the cask is submitted to the correct repo.
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

Used samsung-portable-ssd-t7 Cask as model because of similarities.

[breckwagner]

I'm pretty sure the install step is failing in the Github action because the installer prompts for GDPR and EULA. I'm not sure how to handle it?

[bevanjkay]

Thanks @breckwagner - we require that all software in homebrew-cask be able to be installed without further intervention (entirely headlessly).
The option are to find a way to suppress the warnings, or using installer manual may be the only option.

[breckwagner]

Would something like this be acceptable?

   # ...

  #pkg "Samsung_Magician_installer_Official_#{version}.pkg"
  pkg "Samsung_Magician_installer_Official_#{version}_modified.pkg"

  preflight do
    system "pkgutil", "--expand", "#{staged_path}/Samsung_Magician_installer_Official_#{version}.pkg", "#{staged_path}/Package_Content"
    system("sed -i -e '/ PRIVACY POLICY NOTICE\\/AGREEMENT /,/#\\*/ s/^/#/g' #{staged_path}/Package_Content/SamsungMagicianSVC.pkg/Scripts/preinstall")
    system "pkgutil", "--flatten", "#{staged_path}/Package_Content", "#{staged_path}/Samsung_Magician_installer_Official_#{version}_modified.pkg"
  end

   # ...

[bevanjkay]

I don't think we should be modifying the installer. There's an expectation that when installing a cask we simply automate installing the software as provided by upstream.

[breckwagner]

I agree. It would be annoying to maintain. The pkg contains a preinstall script which contains calls to osascript to display alerts and dialogs. I don't know how to suppress them.