Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft-teams 23247.720.2421.8365 #157225

Merged
merged 1 commit into from
Oct 11, 2023
Merged

microsoft-teams 23247.720.2421.8365 #157225

merged 1 commit into from
Oct 11, 2023

Conversation

sergiotocalini
Copy link
Contributor

@sergiotocalini sergiotocalini commented Oct 10, 2023

This PR follows the announcement of the new Microsoft Teams version.

https://www.microsoft.com/en-us/microsoft-teams/download-app

It has an open discussion as well: https://github.com/orgs/Homebrew/discussions/4834

@miccal miccal added the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 10, 2023
@miccal
Copy link
Member

miccal commented Oct 10, 2023

FYI: I have been using the new version of Teams for a while:

https://github.com/miccal/homebrew-miccal/blob/master/Casks/m-microsoft-teams.rb

I have this installed with the standard microsoft-teams Cask, and they do not conflict with each other as far as I can see, since the old one gets re-named to Microsoft Teams classic.app and the new one is currently called Microsoft Teams (work or school).app.

(And in typical Microsoft fashion, the new one is even more terrible than the old one.)

@p-linnane
Copy link
Member

The Classic one should live in homebrew-cask-versions. Good with this otherwise.

@miccal
Copy link
Member

miccal commented Oct 11, 2023

Homebrew/homebrew-cask-versions#17982

@miccal miccal changed the title Adding Microsoft Teams New and moving old to Classic microsoft-teams 23247.720.2421.8365 Oct 11, 2023
@p-linnane p-linnane removed the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 11, 2023
@p-linnane p-linnane enabled auto-merge October 11, 2023 15:40
@p-linnane p-linnane merged commit 509094f into Homebrew:master Oct 11, 2023
@muescha
Copy link
Contributor

muescha commented Oct 11, 2023

it not show up in brew outdated
microsoft teams 1.6.x do not ask for an upgrade itself

whats the best "upgrade" path? do a force reinstall?

@zauni
Copy link

zauni commented Oct 13, 2023

@muescha In my case it looks like Homebrew did not recognize that Teams was renamed to "Teams classic" or something like that, and it thought I did not install it at all (brew ls did not show it). So a normal brew install microsoft-teams was enough to get the new Teams version installed alongside the Classic Teams.

@mxmo0rhuhn
Copy link

Hi guys, it's great to see that the new teams made it to homebrew so fast!
I have a question regarding the microsoft-office-businesspro bundle (https://github.com/Homebrew/homebrew-cask/blob/90b10375bd45de9798f3f392b388f6671cbd9912/Casks/m/microsoft-office-businesspro.rb): Do I understand it correctly that this cask should now also conflict with the classic teams?
Moreover: Do you have any indication when/how the new teams will be available in this bundle?

@miccal
Copy link
Member

miccal commented Oct 17, 2023

#157915

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants