From 1b548e6c398c87876668d7e4e3208011ed9726e3 Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 00:23:42 +0400 Subject: [PATCH 1/6] add roblox --- Casks/r/roblox.rb | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Casks/r/roblox.rb diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb new file mode 100644 index 0000000000000..8bc66a1292a54 --- /dev/null +++ b/Casks/r/roblox.rb @@ -0,0 +1,33 @@ +cask "roblox" do + version "0.633.1.6330512,a8ca20f2b0e344c3" + sha256 "f7accc2d8c7418abe73193c478a628ce9e5cf95aa12e65039191aa31135b4886" + + url "https://setup.rbxcdn.com/mac/version-#{version.csv.second}-RobloxPlayer.zip", + verified: "setup.rbxcdn.com/" + name "Roblox" + desc "Online multiplayer game platform" + homepage "https://www.roblox.com/" + + livecheck do + url "https://clientsettingscdn.roblox.com/v1/client-version/MacPlayer" + regex(/version":"([^"]+)".*version[._-]([^"]+)/i) + strategy :page_match do |page, regex| + main_version = page[regex, 1] + client_version = page[regex, 2] + "#{main_version},#{client_version}" + end + end + + auto_updates true + + app "RobloxPlayer.app", target: "Roblox.app" + + uninstall quit: "com.roblox.RobloxPlayer", + delete: "/Applications/Roblox.app" + + zap trash: [ + "~/Library/Preferences/com.Roblox.Roblox.plist", + "~/Library/Preferences/com.roblox.RobloxPlayer.plist", + "~/Library/Preferences/com.roblox.RobloxPlayerChannel.plist", + ] +end \ No newline at end of file From fa60227574b7d4d119919ab6f38cdbbb1605eea2 Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 00:29:51 +0400 Subject: [PATCH 2/6] style fix --- Casks/r/roblox.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb index 8bc66a1292a54..cc181880d3298 100644 --- a/Casks/r/roblox.rb +++ b/Casks/r/roblox.rb @@ -30,4 +30,4 @@ "~/Library/Preferences/com.roblox.RobloxPlayer.plist", "~/Library/Preferences/com.roblox.RobloxPlayerChannel.plist", ] -end \ No newline at end of file +end From 75fbbf929005987d176b88afd3d28bb572d73983 Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 00:37:15 +0400 Subject: [PATCH 3/6] audit fix --- Casks/r/roblox.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb index cc181880d3298..5e37f3ea34627 100644 --- a/Casks/r/roblox.rb +++ b/Casks/r/roblox.rb @@ -19,6 +19,7 @@ end auto_updates true + depends_on macos: ">= :high_sierra" app "RobloxPlayer.app", target: "Roblox.app" @@ -30,4 +31,8 @@ "~/Library/Preferences/com.roblox.RobloxPlayer.plist", "~/Library/Preferences/com.roblox.RobloxPlayerChannel.plist", ] + + caveats do + requires_rosetta + end end From 9319ee986d4ee87f56f56be423e66aeb6be52321 Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 12:59:02 +0400 Subject: [PATCH 4/6] update livecheck --- Casks/r/roblox.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb index 5e37f3ea34627..d0722b6721f00 100644 --- a/Casks/r/roblox.rb +++ b/Casks/r/roblox.rb @@ -10,11 +10,11 @@ livecheck do url "https://clientsettingscdn.roblox.com/v1/client-version/MacPlayer" - regex(/version":"([^"]+)".*version[._-]([^"]+)/i) - strategy :page_match do |page, regex| - main_version = page[regex, 1] - client_version = page[regex, 2] - "#{main_version},#{client_version}" + strategy :json do |json| + version = json["version"] + client_version = json["clientVersionUpload"]&.split("-")&.second + next if version.blank? || client_version.blank? + "#{version},#{client_version}" end end From d5e8cb3b1cf63de947d9341862572be639e4310c Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 13:06:56 +0400 Subject: [PATCH 5/6] style fix --- Casks/r/roblox.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb index d0722b6721f00..eb8548a18b564 100644 --- a/Casks/r/roblox.rb +++ b/Casks/r/roblox.rb @@ -14,6 +14,7 @@ version = json["version"] client_version = json["clientVersionUpload"]&.split("-")&.second next if version.blank? || client_version.blank? + "#{version},#{client_version}" end end From c596700843ed72afd6ec9c53b21f2da548f9c626 Mon Sep 17 00:00:00 2001 From: lucky Date: Tue, 16 Jul 2024 13:11:29 +0400 Subject: [PATCH 6/6] add comment about renaming the app --- Casks/r/roblox.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Casks/r/roblox.rb b/Casks/r/roblox.rb index eb8548a18b564..1238e6659761a 100644 --- a/Casks/r/roblox.rb +++ b/Casks/r/roblox.rb @@ -22,6 +22,7 @@ auto_updates true depends_on macos: ">= :high_sierra" + # The default installer installs the application as `Roblox.app` - so do the same for consistency app "RobloxPlayer.app", target: "Roblox.app" uninstall quit: "com.roblox.RobloxPlayer",