From 37f034550c4573ff170a869dc68c670f5623681b Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 8 Jan 2025 16:06:34 +0000 Subject: [PATCH] brew_installer: fail if services or link fails. This is the more expected behaviour and more consistent with e.g. `brew bundle check`. --- lib/bundle/brew_installer.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/bundle/brew_installer.rb b/lib/bundle/brew_installer.rb index c21f4a5539..02499ab8d1 100644 --- a/lib/bundle/brew_installer.rb +++ b/lib/bundle/brew_installer.rb @@ -43,13 +43,18 @@ def install(preinstall: true, no_upgrade: false, verbose: false, force: false) else true end + result = install_result if installed? - service_change_state!(verbose:) if install_result - link_change_state!(verbose:) + if install_result + service_result = service_change_state!(verbose:) + result &&= service_result + end + link_result = link_change_state!(verbose:) + result &&= link_result end - install_result + result end def install_change_state!(no_upgrade:, verbose:, force:)