Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brewfile.lock.json generation. #1509

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Remove Brewfile.lock.json generation. #1509

merged 1 commit into from
Nov 27, 2024

Conversation

MikeMcQuaid
Copy link
Member

This was originally added to faciliate later functionality from other maintainers that never materialized.

I've never heard anyone say this was useful and a lot of people have complained that it's useless or annoying.

I won't merge this immediately to give people a change to comment.

This was originally added to faciliate later functionality from other
maintainers that never materialized.

I've never heard anyone say this was useful and a lot of people have
complained that it's useless or annoying.
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I've also never understood the purpose, so your explanation makes sense.

@colindean
Copy link
Member

I have no objections. I've got a line for Brewfile.lock.json in every .gitignore in a repo with a Brewfile.

@jacobbednarz
Copy link
Member

works for me!

@p-linnane p-linnane merged commit 1419e23 into master Nov 27, 2024
5 checks passed
@p-linnane p-linnane deleted the remove_lockfile branch November 27, 2024 00:48
@Brett-Best
Copy link

I actually found this helpful and had it committed to the repository.
It had a bunch of information about the environment in a last known working state which made finding where things broke a bit easier to debug.

It's not a big deal but perhaps it could default to not generating the lockfile and make it opt in only.

Okeanos added a commit to Okeanos/dotfiles that referenced this pull request Dec 7, 2024
minusfive added a commit to minusfive/dotfiles that referenced this pull request Dec 13, 2024
Lock file generation feature was removed from homebrew-bundle
a couple of weeks ago:

Homebrew/homebrew-bundle#1509
@georgettica
Copy link

I also used it and was surprised it was removed. I used it to un-quarantine casks after each release.

@Xe
Copy link

Xe commented Dec 22, 2024

My CI relied on this for caching homebrew packages so they didn't have to be downloaded twice (this saves up to 10 minutes per CI run). Is there a way to re-enable spacebar heating?

ekweible added a commit to ekweible/dotfiles that referenced this pull request Dec 23, 2024
@MikeMcQuaid
Copy link
Member Author

Thanks for chiming in @georgettica @Xe! Can you elaborate on how you used/consumed this? Thanks!

@georgettica
Copy link

As I didn't have a automated way to test what packages have changed on my machine, I added this file to my git and for each cask that was updated I force the PKG to be un-quarantined, this reduce the "are you sure this package is secure" warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants