Skip to content

Commit f3fe7e5

Browse files
authored
Merge pull request #587 from Homebrew/create-pull-request-improvements
create-pull-request: fix empty string handling
2 parents c4fb4dc + b751a77 commit f3fe7e5

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

create-pull-request/main.mjs

+13-4
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ async function main() {
1111
const title = core.getInput("title")
1212
const body = core.getInput("body")
1313

14-
const labels = core.getInput("labels").split(",")
15-
const reviewers = core.getInput("reviewers").split(",")
14+
const labelsInput = core.getInput("labels")
15+
const labels = labelsInput ? labelsInput.split(",") : []
16+
const reviewersInput = core.getInput("reviewers")
17+
const reviewers = reviewersInput ? reviewersInput.split(",") : []
1618

1719
const client = github.getOctokit(token)
1820

@@ -27,23 +29,30 @@ async function main() {
2729
const response = await client.rest.pulls.create(prRequest)
2830
const prNumber = response.data.number
2931
const prNodeId = response.data.node_id
32+
const prUrl = response.data.html_url
3033

31-
if (labels) {
34+
core.info(`Created pull request ${prUrl}`)
35+
36+
if (labels.length > 0) {
3237
await client.rest.issues.addLabels({
3338
owner,
3439
repo,
3540
issue_number: prNumber,
3641
labels
3742
})
43+
44+
core.info(`Added labels ${labels.join(", ")} to pull request`)
3845
}
3946

40-
if (reviewers) {
47+
if (reviewers.length > 0) {
4148
await client.rest.pulls.requestReviewers({
4249
owner,
4350
repo,
4451
pull_number: prNumber,
4552
reviewers
4653
})
54+
55+
core.info(`Requested review from ${reviewers.join(", ")} for pull request`)
4756
}
4857

4958
core.setOutput("number", prNumber)

0 commit comments

Comments
 (0)