Skip to content

Fix TextInputDialog focus on launch #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TextInputDialog focus on launch #2051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions app/src/main/java/helium314/keyboard/settings/dialogs/TextInputDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,6 @@ fun TextInputDialog(
reducePadding: Boolean = false,
checkTextValid: (text: String) -> Boolean = { it.isNotBlank() }
) {
val focusRequester = remember { FocusRequester() }
// crappy workaround because otherwise we get a disappearing dialog and a crash
// but doesn't work perfectly, dialog doesn't nicely show up again...
// todo: understand why it works in ExpandableSearchField, but not here
var done by rememberSaveable { mutableStateOf(false) }
LaunchedEffect(initialText) {
if (done) return@LaunchedEffect
focusRequester.requestFocus()
done = true
}

var value by rememberSaveable(stateSaver = TextFieldValue.Saver) {
mutableStateOf(TextFieldValue(initialText, selection = TextRange(if (singleLine) initialText.length else 0)))
}
Expand All @@ -69,6 +58,7 @@ fun TextInputDialog(
modifier = modifier,
title = title,
content = {
val focusRequester = remember { FocusRequester() }
OutlinedTextField(
value = value,
onValueChange = { value = it },
Expand All @@ -80,6 +70,7 @@ fun TextInputDialog(
singleLine = singleLine,
textStyle = contentTextDirectionStyle,
)
LaunchedEffect(Unit) { focusRequester.requestFocus() }
},
properties = properties,
reducePadding = reducePadding,
Expand Down
Loading