Skip to content

Conversation

@eranl
Copy link
Contributor

@eranl eranl commented Jul 19, 2025

Currently, when you press backspace, any existing phantom space is canceled, and the character before it is deleted.

With this change, if in phantom space mode, only that space is deleted on the first press, to give the user more control.

This is another alternative for the No autospace when pressing shift setting, which is problematic in some situations. See #1773, #1777.

Should this be guarded by a setting?

#1805 could make this clearer.

I tried to make the code change as light as possible, but I might have missed some details.

@Helium314
Copy link
Owner

It should definitely be a setting, this behavior appears like a bug to a user who doesn't know of this setting.

It's not working for glide typing, because the code is after the rejectedSuggestion branch in handleBackspaceEvent.

@Helium314
Copy link
Owner

#1805 could make this clearer.

If it's possible, a changed cursor would definitely help. Maybe also some styling is possible using Spanned (like getTextWithUnderline does).

@eranl
Copy link
Contributor Author

eranl commented Jul 27, 2025

It should definitely be a setting

Should I combine it with the existing No autospace when pressing shift setting into a list preference (that would require some upgrade logic obviously)? Should they be mutually exclusive?

It's not working for glide typing, because the code is after the rejectedSuggestion branch in handleBackspaceEvent.

Fixed, but without updating suggestions, since that would prevent rejecting the gestured word.

@eranl
Copy link
Contributor Author

eranl commented Jul 28, 2025

If it's possible, a changed cursor would definitely help. Maybe also some styling is possible using Spanned (like getTextWithUnderline does).

See #1805 (comment).

@Helium314
Copy link
Owner

Fixed, but without updating suggestions, since that would prevent rejecting the gestured word.

Makes sense. Here the need for an indicator is clearly greater than for selecting a suggestion, as the underline under the word is there all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants