Skip to content

Triggering of haptic and audio feedback during cursor movement on spacebar swipe #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Triggering of haptic and audio feedback during cursor movement on spacebar swipe #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f796b99
Added triggering of haptic and audio feedback during cursor movement …
Aug 5, 2024
9e3d989
Removed audio feedback on cursor move
Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/java/helium314/keyboard/keyboard/KeyboardActionListenerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ class KeyboardActionListenerImpl(private val latinIME: LatinIME, private val inp
return true
}
}

latinIME.hapticCursorFeedback()

if (inputLogic.moveCursorByAndReturnIfInsideComposingWord(moveSteps)) {
// no need to finish input and restart suggestions if we're still in the word
// this is a noticeable performance improvement
Expand Down
18 changes: 18 additions & 0 deletions app/src/main/java/helium314/keyboard/latin/AudioAndHapticFeedbackManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import android.content.Context;
import android.media.AudioManager;
import android.os.Build;
import android.os.Vibrator;
import android.view.HapticFeedbackConstants;
import android.view.View;
Expand Down Expand Up @@ -105,6 +106,23 @@ public void performHapticFeedback(final View viewToPerformHapticFeedbackOn) {
HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING);
}
}

public void performHapticCursorFeedback(final View viewToPerformHapticFeedbackOn) {
if (!mSettingsValues.mVibrateOn) {
return;
}
if (viewToPerformHapticFeedbackOn != null) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O_MR1) {
viewToPerformHapticFeedbackOn.performHapticFeedback(
HapticFeedbackConstants.TEXT_HANDLE_MOVE,
HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING);
}else {
Copy link
Contributor

@PurplePickleMonster PurplePickleMonster Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}else {
} else {

viewToPerformHapticFeedbackOn.performHapticFeedback(
HapticFeedbackConstants.CLOCK_TICK,
HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING);
}
}
}

public void onSettingsChanged(final SettingsValues settingsValues) {
mSettingsValues = settingsValues;
Expand Down
6 changes: 6 additions & 0 deletions app/src/main/java/helium314/keyboard/latin/LatinIME.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1747,6 +1747,12 @@ private void updateStateAfterInputTransaction(final InputTransaction inputTransa
}
}

public void hapticCursorFeedback() {
final MainKeyboardView keyboardView = mKeyboardSwitcher.getMainKeyboardView();
final AudioAndHapticFeedbackManager feedbackManager = AudioAndHapticFeedbackManager.getInstance();
feedbackManager.performHapticCursorFeedback(keyboardView);
}

public void hapticAndAudioFeedback(final int code, final int repeatCount) {
final MainKeyboardView keyboardView = mKeyboardSwitcher.getMainKeyboardView();
if (keyboardView != null && keyboardView.isInDraggingFinger()) {
Expand Down