From c72cdff02abaf28c81b4336a98aa5d5e083de7b9 Mon Sep 17 00:00:00 2001 From: MiMoHo Date: Thu, 23 Jul 2026 03:36:33 +0200 Subject: [PATCH 1/2] DynamicColors: dim the Holo popup selection highlight in dark mode The long-press popup's selected key was highlighted with the full accent (system_accent1_100), which is glaringly light on the dark keyboard. Use the darkened accent (doubleAdjustedAccent) for the Holo popup highlight in dark mode, matching how the Material night popup already uses a darkened accent, so the selection is still clearly marked but not blindingly bright. Co-Authored-By: Claude Opus 4.8 --- app/src/main/java/helium314/keyboard/latin/common/Colors.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/helium314/keyboard/latin/common/Colors.kt b/app/src/main/java/helium314/keyboard/latin/common/Colors.kt index e14e10b8fe..f1e90fe159 100644 --- a/app/src/main/java/helium314/keyboard/latin/common/Colors.kt +++ b/app/src/main/java/helium314/keyboard/latin/common/Colors.kt @@ -196,7 +196,9 @@ class DynamicColors(context: Context, override val themeStyle: String, override } adjustedBackgroundStateList = if (themeStyle == STYLE_HOLO) { - pressedStateList(accent, adjustedBackground) + // in dark mode the popup selection highlight (system_accent1_100) is glaringly light; + // dim it, matching how the Material night popup already uses a darkened accent + pressedStateList(if (isNight) doubleAdjustedAccent else accent, adjustedBackground) } else if (isNight) { if (hasKeyBorders) pressedStateList(doubleAdjustedAccent, keyBackground) else pressedStateList(adjustedAccent, adjustedKeyBackground) From 3be6a6b251a1c5dd16a98d2ff7ff274792f0036f Mon Sep 17 00:00:00 2001 From: MiMoHo Date: Thu, 23 Jul 2026 04:22:30 +0200 Subject: [PATCH 2/2] Static themes: use the accent for the popup selection highlight The popup selection highlight in the static themes used doubleAdjustedBackground, a barely-visible background shade. Use the theme accent instead, so the popup key highlighting is clearly noticeable (#2440) and consistent with the dynamic theme. Co-Authored-By: Claude Opus 4.8 --- app/src/main/java/helium314/keyboard/latin/common/Colors.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/helium314/keyboard/latin/common/Colors.kt b/app/src/main/java/helium314/keyboard/latin/common/Colors.kt index f1e90fe159..453c1c0287 100644 --- a/app/src/main/java/helium314/keyboard/latin/common/Colors.kt +++ b/app/src/main/java/helium314/keyboard/latin/common/Colors.kt @@ -417,7 +417,9 @@ class DefaultColors ( adjustedBackground = darken(background) doubleAdjustedBackground = darken(adjustedBackground) } - adjustedBackgroundStateList = pressedStateList(doubleAdjustedBackground, adjustedBackground) + // popup selection highlight uses the theme accent so it is clearly noticeable (#2440), + // consistent with the dynamic theme, instead of the barely-visible doubleAdjustedBackground + adjustedBackgroundStateList = pressedStateList(accent, adjustedBackground) val stripBackground: Int val pressedStripElementBackground: Int