Skip to content

Add Edit buttons for custom presets #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JordanLongstaff wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add Edit buttons for custom presets #5994

JordanLongstaff wants to merge 3 commits into from

Conversation

@JordanLongstaff
Copy link
Contributor

@JordanLongstaff JordanLongstaff commented Nov 28, 2025 •
edited by github-actions bot
Loading

@TheLynk TheLynk mentioned this pull request Dec 1, 2025
Draft
@Malkierian
Copy link
Contributor

Malkierian commented Jan 4, 2026

My only question on this is whether it would be worth the extra UI for reducing the flow by 1 step. With what is available now, you could just delete, then click new, select sections, and save. The only difference would be that you don't have to type in the preset name again.

@serprex serprex requested a review from Malkierian January 5, 2026 13:45
@JordanLongstaff
Copy link
Contributor Author

JordanLongstaff commented Jan 5, 2026

I'd argue that just that little extra simplification would still go a long way to improve the UI. I much prefer having an existing preset to modify, over having to throw one away and remake it effectively from scratch.

Pepper0ni
Pepper0ni approved these changes Jan 18, 2026
View reviewed changes
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, as long as we have same name enforcement having an official way to change an existing preset is better than expecting people to delete and recreate, which some people may not intuit or feel nervous about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Malkierian Malkierian Malkierian approved these changes

+1 more reviewer

@Pepper0ni Pepper0ni Pepper0ni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Edit existing presets

3 participants

@JordanLongstaff @Malkierian @Pepper0ni