Makes the bundle compatible with Symfony 5.3+ (#6)

* Makes the bundle compatible with Symfony 5.3+

* Casts the value to string, because Symfony requires it to be a string

* Allows PHP 8

Co-authored-by: Michel Maas <[email protected]>

Author: AxaliaN

.gitignore

@@ -1,3 +1,4 @@
 /vendor/
 /composer.lock
 /php_cs.cache
+.phpunit.result.cache

composer.json

@@ -14,12 +14,12 @@
     }
   ],
   "require": {
-    "php": "^7.2",
-    "symfony/validator": "^3.4 || ^4.3",
+    "php": "^7.2||^8.0",
+    "symfony/validator": "^3.4 || ^4.3 || ^5.0",
     "doctrine/orm": "^2.4"
   },
   "require-dev": {
-    "symfony/phpunit-bridge": "^4.3"
+    "symfony/phpunit-bridge": "^4.3 || ^5.0"
   },
   "autoload": {
     "psr-4": {

src/EntityExistValidator.php

@@ -43,7 +43,7 @@ public function validate($value, Constraint $constraint): void
             $this->context->buildViolation($constraint->message)
                 ->setParameter('%entity%', $constraint->entity)
                 ->setParameter('%property%', $constraint->property)
-                ->setParameter('%value%', $value)
+                ->setParameter('%value%', (string) $value)
                 ->addViolation();
         }
     }

tests/EntityExistValidatorTest.php

@@ -34,21 +34,21 @@ protected function setUp(): void
         $this->validator->initialize($this->context);
     }
 
-    public function testValidateWithWrongConstraint()
+    public function testValidateWithWrongConstraint(): void
     {
         $this->expectException(\LogicException::class);
         $this->validator->validate('foo', new  NotNull());
     }
 
-    public function testValidateWithNoEntity()
+    public function testValidateWithNoEntity(): void
     {
         $constraint = new  EntityExist();
 
         $this->expectException(\LogicException::class);
         $this->validator->validate('foobar', $constraint);
     }
 
-    public function testValidateValidEntity()
+    public function testValidateValidEntity(): void
     {
         $this->context->expects($this->never())->method('buildViolation');
         $constraint = new  EntityExist();
@@ -57,6 +57,7 @@ public function testValidateValidEntity()
         $repository = $this->getMockBuilder(EntityRepository::class)
             ->disableOriginalConstructor()
             ->getMock();
+
         $repository
             ->expects($this->once())
             ->method('findOneBy')
@@ -75,7 +76,7 @@ public function testValidateValidEntity()
     /**
      * @dataProvider getEmptyOrNull
      */
-    public function testValidateSkipsIfValueEmptyOrNull($value)
+    public function testValidateSkipsIfValueEmptyOrNull($value): void
     {
         $this->context->expects($this->never())->method('buildViolation');
         $constraint = new  EntityExist();
@@ -84,6 +85,7 @@ public function testValidateSkipsIfValueEmptyOrNull($value)
         $repository = $this->getMockBuilder(EntityRepository::class)
             ->disableOriginalConstructor()
             ->getMock();
+
         $repository
             ->expects($this->exactly(0))
             ->method('findOneBy')
@@ -99,13 +101,13 @@ public function testValidateSkipsIfValueEmptyOrNull($value)
         $this->validator->validate($value, $constraint);
     }
 
-    public function getEmptyOrNull()
+    public function getEmptyOrNull(): \Generator
     {
         yield [''];
         yield [null];
     }
 
-    public function testValidateValidEntityWithCustomProperty()
+    public function testValidateValidEntityWithCustomProperty(): void
     {
         $this->context->expects($this->never())->method('buildViolation');
         $constraint = new  EntityExist();
@@ -115,6 +117,7 @@ public function testValidateValidEntityWithCustomProperty()
         $repository = $this->getMockBuilder(EntityRepository::class)
             ->disableOriginalConstructor()
             ->getMock();
+
         $repository
             ->expects($this->once())
             ->method('findOneBy')
@@ -130,7 +133,7 @@ public function testValidateValidEntityWithCustomProperty()
         $this->validator->validate('foobar', $constraint);
     }
 
-    public function testValidateInvalidEntity()
+    public function testValidateInvalidEntity(): void
     {
         $violationBuilder = $this->getMockBuilder(ConstraintViolationBuilderInterface::class)->getMock();
         $violationBuilder->method('setParameter')->will($this->returnSelf());
@@ -142,6 +145,7 @@ public function testValidateInvalidEntity()
         $repository = $this->getMockBuilder(EntityRepository::class)
             ->disableOriginalConstructor()
             ->getMock();
+
         $repository
             ->expects($this->once())
             ->method('findOneBy')
@@ -152,6 +156,6 @@ public function testValidateInvalidEntity()
             ->method('getRepository')
             ->willReturn($repository);
 
-        $this->validator->validate('foobar', $constraint);
+        $this->validator->validate(1, $constraint);
     }
 }