[refactor] 쪽지 작성 기능 리팩토링 #299 #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2unbini
approved these changes
Jul 6, 2023
| @@ -45,7 +45,7 @@ final class BaseTextView: UITextView { | |||
|
|
|||
| private func subscribeToFontPublisher() { | |||
| self.cancellable = fontManager.fontPublisher | |||
| .receive(on: DispatchQueue.main) | |||
| // .receive(on: DispatchQueue.main) | |||
There was a problem hiding this comment.
이거 updateFont(to:isBold:) 함수에서 UIFont(name: .system)이 없는건 아닐까요?
아니면 fontManager가 싱글턴이니까 상위 뷰에서 먼저 설정되어야 하는 부분을 건너뛰어서 여기서 크래시가 나는 것은 아닌가 합니다!
만약 저 객체 자체가 뭔가 이니셜라이징이 제대로 안 되어있으면 전체 뷰에서 문제가 날 수도 있겠다는 생각이 듭니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
클래스/메서드/swift 파일 이름 등
리뷰 사항