Team and staff schema and routes #295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasminerliu
commented
Oct 28, 2025
jasminerliu
commented
- Created team-schema.ts, team-router.ts, and team-router.test.ts, and relevant table and routes, which is referenced by StaffInfo.
- Added optional reference to StaffInfo in UserInfo, which is only set if a User is a staff member
- Created StaffInfo table that builds on UserInfo and references Team, and relevant routes.
- concerned about the permission scopes i set for routes, like for creating/updating/deleting staff info i have it as admin, not sure what it should be exactly.
jasminerliu
force-pushed
the
team-and-staff-schema-routes
branch
from
e14396d to
31edb37
Compare
…user info table, and all associated routes and tests
jasminerliu
force-pushed
the
team-and-staff-schema-routes
branch
from
31edb37 to
12341f6
Compare
J164
requested changes
Oct 29, 2025
Member
J164
left a comment
J164
left a comment
There was a problem hiding this comment.
I'm wondering if it's necessary to associate StaffInfo with a particular user in the system. As far as I'm aware we only plan to use this to more easily update the info site. Lmk what you think
Comment on lines
+62
to
+63
| const userInfo = staff.user as unknown as UserInfo; | ||
| const team = staff.team as unknown as Team; |
Member
There was a problem hiding this comment.
This seems kinda cursed. Why do we need these casts?
Comment on lines
+228
to
+232
| z.object({ | ||
| userId: UserIdSchema, | ||
| name: z.string(), | ||
| email: z.string(), | ||
| }), |
Member
There was a problem hiding this comment.
Can we define this as a separate variable? (like AttendeeInfoSchema)
Comment on lines
+104
to
+107
| const userInfo = await Models.UserInfo.findOne({ userId }); | ||
| if (!userInfo) { | ||
| return res.status(StatusCode.ClientErrorNotFound).json(UserNotFoundError); | ||
| } |
Member
There was a problem hiding this comment.
Ideally this feature would work even if the user has never signed in. Can we avoid tying staffInfo to the actual user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.