Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May need to add plotly and dittoSeq as dependencies #1

Open
NeginValizadegan opened this issue Oct 28, 2022 · 1 comment
Open

May need to add plotly and dittoSeq as dependencies #1

NeginValizadegan opened this issue Oct 28, 2022 · 1 comment

Comments

@NeginValizadegan
Copy link

The DESCRIPTION says plotly_microbiome imports plotly, dittoSeq, viridis, and rlang. If you don't have these installed (specifically I had issues with plotly and dittoSeq), there will be a problem with loading this package unless you install these packages separately. These might be needed to be added as dependency or installed automatically as part of package installation.

@lvclark
Copy link
Member

lvclark commented Oct 28, 2022

Following CRAN conventions, most packages whose functions are used in the package code should be in the Imports field. Depends is only for extreme cases where a package is designed to build off of an existing one, and there's no point to having the package loaded without having its dependency loaded.

See https://mirror.las.iastate.edu/CRAN/doc/manuals/r-release/R-exts.html#Package-Dependencies, and probably some cranky email I received in the past from CRAN telling me I'm Doing It Wrong.

Maybe update the installation instructions instead? If the package were installed from CRAN, everything in Imports would get installed, but perhaps it isn't that way with R-universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants