支持多条的正则表达式, 支持弹幕合并, #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢贡献，如果引入了新的boost文件，需要相应进行添加，不然CI会失败 |
|
如果C++内部不好做正则可以考虑在python中进行过滤，应该不至于影响太多性能 |
boost的正则对utf8的处理也不好, 所以没加, 用的还是std |
弹幕合并是在正则过滤前进行的, 在python里过滤会把相同内容的弹幕反复判断 |
|
CI我来看看吧，没有加入新的文件应该就没有问题。自测没有问题后可以merge |
|
有进展吗？没计划我可以新开一个 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13, close #14
\n分割的多条的正则表达式, 但对utf8字符的处理仍有问题, std和boost的regex都不能很好的处理utf8