Skip to content

Commit 49e75eb

Browse files
committed
Refine some smart-home-interface comments and descriptions
1 parent f8a11e3 commit 49e75eb

File tree

3 files changed

+28
-11
lines changed

3 files changed

+28
-11
lines changed

luxtronik/datatypes.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,8 @@ class ControlMode(SelectionBase):
877877
0: "Off", # System value is used
878878
1: "Setpoint", # Setpoint register value is used
879879
2: "Offset", # System values + offset register value is used
880-
3: "Level",
880+
3: "Level", # System values + smart-home-interface-settings
881+
# register value is used
881882
}
882883

883884

@@ -887,9 +888,9 @@ class LpcMode(SelectionBase):
887888
datatype_class = "selection"
888889

889890
codes = {
890-
0: "No-Limit",
891-
1: "Soft-Limit",
892-
2: "Hard-Limit",
891+
0: "No limit",
892+
1: "Soft limit",
893+
2: "Hard limit",
893894
}
894895

895896

@@ -899,8 +900,8 @@ class LockMode(SelectionBase):
899900
datatype_class = "selection"
900901

901902
codes = {
902-
0: "Unlocked / Off",
903-
1: "Locked / On",
903+
0: "Off", # Function is not locked
904+
1: "On", # Function is locked
904905
}
905906

906907
class OnOffMode(SelectionBase):
@@ -920,9 +921,15 @@ class LevelMode(SelectionBase):
920921

921922
codes = {
922923
0: "Normal", # No correction
923-
1: "Increased", # Increase the temperature by the values within the SHI-settings
924-
2: "Increased", # Increase the temperature by the values within the SHI-settings
925-
3: "Decreased", # Decrease the temperature by the values within the SHI-settings
924+
1: "Increased", # Increase the temperature by the values
925+
# within the smart-home-interface-settings
926+
# TODO: Function unknown – requires further analysis
927+
2: "Increased2", # Increase the temperature by the values
928+
# within the smart-home-interface-settings
929+
# TODO: Function unknown – requires further analysis
930+
3: "Decreased", # Decrease the temperature by the values
931+
# within the smart-home-interface-settings
932+
# TODO: Function unknown – requires further analysis
926933
}
927934

928935
class PowerLimit(ScalingBase):

luxtronik/definitions/holdings.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
"""
2-
Constant list containing the complete holdings definitions.
2+
Constant list containing all 'holdings' definitions
3+
used by the Smart Home Interface (SHI) of the Luxtronik controller.
4+
5+
Unlike the setting registers, these SHI register are volatile and intended for
6+
communication with smart home systems. 'Holding' registers are readable
7+
and writable and are used to control the heat pump externally.
38
"""
49
from luxtronik.datatypes import (
510
Celsius,

luxtronik/definitions/inputs.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
"""
2-
Constant list containing the complete inputs definitions.
2+
Constant list containing all 'inputs' definitions
3+
used by the Smart Home Interface (SHI) of the Luxtronik controller.
4+
5+
Unlike the setting registers, these SHI register are volatile and intended for
6+
communication with smart home systems. 'Input' register are read-only
7+
and are used for display or to control other devices.
38
"""
49
from luxtronik.datatypes import (
510
Celsius,

0 commit comments

Comments
 (0)