Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial spawner breaking results in false FastBreak #1962

Open
metabrixkt opened this issue Jan 23, 2025 · 2 comments
Open

Trial spawner breaking results in false FastBreak #1962

metabrixkt opened this issue Jan 23, 2025 · 2 comments
Labels
false positive False positive help wanted Extra attention is needed

Comments

@metabrixkt
Copy link
Contributor

Describe the false positive and how to replicate it

  1. Place a trial spawner
  2. Break the trial spawner you just placed...
Grim » JohnDoe failed FastBreak (x1) Diff=175090.0,Balance=176090.0
  1. The block break gets cancelled and the trial spawner reappears

A few separate attempts to reproduce this with efficiency V resulted in these logs:

Grim » JohnDoe failed FastBreak (x1) Diff=175050.0,Balance=175050.0
Grim » JohnDoe failed FastBreak (x1) Diff=175109.0,Balance=176109.0

Grim version

31394f4

Server version

Paper 1.21.3-82-5a60ffb

Client version

Vanilla 1.21.3

Plugins

  • GrimAC 2.3.69 (31394f4)
  • ProtocolLib 5.3.0
  • ViaVersion 5.2.1 (supporting 1.21-1.21.4 clients, though the bug is reproducible with the client version matching the server version, i.e. 1.21.3 in this case)
  • ViaBackwards 5.2.1
@metabrixkt metabrixkt added the false positive False positive label Jan 23, 2025
@metabrixkt metabrixkt changed the title Trial spawner breaking results in FastBreak Trial spawner breaking results in false FastBreak Jan 23, 2025
@SamB440
Copy link
Contributor

SamB440 commented Jan 24, 2025

Can confirm but it takes a decade to break and the block hardness values seem correct

@SamB440 SamB440 added the help wanted Extra attention is needed label Jan 30, 2025
@SamB440
Copy link
Contributor

SamB440 commented Jan 30, 2025

As a temporary fix to not annoy legit players, I have exempted this block entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive False positive help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants