Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot retrieve map name from s2gs for Megaton Team Monobattles #78

Open
dsjoerg opened this issue Nov 23, 2012 · 3 comments
Open

Cannot retrieve map name from s2gs for Megaton Team Monobattles #78

dsjoerg opened this issue Nov 23, 2012 · 3 comments

Comments

@dsjoerg
Copy link
Collaborator

dsjoerg commented Nov 23, 2012

>>> wget eu.depot.battle.net:1119/e777780e13cae31b39e0a30609c9272f539e172392339f2b992dcbe3de69823f.s2gs
>>> s2gsfile = open("e777780e13cae31b39e0a30609c9272f539e172392339f2b992dcbe3de69823f.s2gs", "rb")
>>> summary = sc2reader.load_game_summary(s2gsfile)
>>> summary.map_name
'Teams 04 (Mod)'

Within the SC2 client, the map name is shown as Megaton Team Monobattles.
Perhaps this is unsolvable, but I thought it was worth a look.

@ghost ghost assigned GraylinKim Mar 25, 2013
@GraylinKim
Copy link
Owner

This is another localization issue. The map data wasn't translated into English so there was no 5th sheet with map information. Unfortunately the 'enGB' localization didn't have 'Megaton Team Monobattles' as the map name. It had 'TSL4 Antiga Shipyard'. So I'm rather confused on this one.

s2gs files aren't as relevant any more so I'm not going to look into it any further unless something changes..

@dsjoerg
Copy link
Collaborator Author

dsjoerg commented May 28, 2013

s2gs files are still relevant -- they will be a useful way of mass-gathering certain kinds of data. but much less urgent than they used to be.

@GraylinKim
Copy link
Owner

Putting this on indefinite hold. Eventually it will make sense to better deal with localization issues in sc2reader. We'll figure out how to handle this when that time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants