Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New s2protocol #193

Open
cjb opened this issue Oct 31, 2016 · 4 comments
Open

New s2protocol #193

cjb opened this issue Oct 31, 2016 · 4 comments

Comments

@cjb
Copy link

cjb commented Oct 31, 2016

Hi, I haven't contributed before, but I see that Spawning Tool's failing to parse new replays and there's a new s2protocol released six days ago:

Blizzard/s2protocol@d62b17c

@StoicLoofah
Copy link

@dsjoerg looks like you already tackled this with your last 3 commits on https://github.com/ggtracker/sc2reader ?

As a general point, I guess it seems that this repo isn't really being maintained, where both ggtracker and spawningtool both maintain forks. should we centralize and have a new official sc2reader repo?

@dsjoerg
Copy link
Collaborator

dsjoerg commented Nov 1, 2016

@StoicLoofah fine by me, I can give you push rights to https://github.com/ggtracker/sc2reader or I can switch to using a new one if you prefer.

@StoicLoofah
Copy link

I'm down to use the ggtracker branch: it's almost certainly the best maintained. I myself am too lazy to write tests 😛

@GraylinKim can you assign @dsjoerg as the owner of sc2reader on pypi so we can start pushing official releases there again?

@EHadoux
Copy link

EHadoux commented Nov 4, 2016

Oh yes, please do that. It was starting to get difficult to untangle everything and to know where to look for and merge. (Although it has been quite some time since the last time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants