Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkeys or Control Groups #114

Closed
GraylinKim opened this issue Apr 9, 2013 · 4 comments
Closed

Hotkeys or Control Groups #114

GraylinKim opened this issue Apr 9, 2013 · 4 comments
Assignees
@GraylinKim
Labels
discussion
Milestone
0.7.0

Comments

@GraylinKim
Copy link
Owner

Why do we call control groups hotkeys? Hotkeys are definitely different.

Is this confusing enough to warrant a fix?
@ghost ghost assigned GraylinKim Apr 9, 2013
@dsjoerg
Copy link
Collaborator

dsjoerg commented Apr 9, 2013

Doesn't bother me :)

@GraylinKim
Copy link
Owner Author

Backwards compatibility is more important.

@GraylinKim
Copy link
Owner Author

We're going to change this. I'll alias the name for all future 0.6.x releases and remove the Hotkey name support in 0.7.0.

  • GetFromHotkey -> FetchControlGroup
  • SetToHotkey -> SetControlGroup
  • AddToHotkey -> AddToControlGroup

sc2reader's poor terminology is starting to catch on. We've gotta fix it.

@GraylinKim GraylinKim reopened this Sep 19, 2013
@GraylinKim
Copy link
Owner Author

This has been fixed by dda41fb. Change will be effective starting with the 0.7.0 release because it will be backwards incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GraylinKim GraylinKim

Labels
discussion
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@GraylinKim @dsjoerg