ImageArchive: allow sdcard images even when os is not debuggable

This allows custom images on production gos builds,
to allow the user to run a different os of their choosing

Users can place images into /storage/emulated/0/linux/images.tar.gz

Author: mkg20001

android/TerminalApp/java/com/android/virtualization/terminal/ImageArchive.kt

@@ -175,12 +175,12 @@ internal class ImageArchive {
         }
 
         /**
-         * Creates ImageArchive from either SdCard or Internet. SdCard is used only when the build
-         * is debuggable and the file actually exists.
+         * Creates ImageArchive from either SdCard or Internet. SdCard is used only when the
+         * file actually exists.
          */
         fun getDefault(): ImageArchive {
             val archive = fromSdCard()
-            return if (Build.isDebuggable() && archive.exists()) {
+            return if (archive.exists()) {
                 archive
             } else {
                 fromInternet()

android/TerminalApp/java/com/android/virtualization/terminal/InstallerActivity.kt

@@ -109,7 +109,7 @@ public class InstallerActivity : BaseActivity() {
     override fun onResume() {
         super.onResume()
 
-        if (autoInstall || (Build.isDebuggable() && fromSdCard().exists())) {
+        if (autoInstall || fromSdCard().exists()) {
             showSnackBar("Auto installing", Snackbar.LENGTH_LONG)
             requestInstall()
         }

android/TerminalApp/java/com/android/virtualization/terminal/InstallerService.kt

@@ -152,11 +152,6 @@ class InstallerService : Service() {
         val archive = fromSdCard()
         val archive_path = archive.getPath()
 
-        // Installing from sdcard is preferred, but only supported only in debuggable build.
-        if (!Build.isDebuggable()) {
-            Log.i(TAG, "Non-debuggable build doesn't support installation from $archive_path")
-            return false
-        }
         if (!archive.exists()) {
             return false
         }