Skip to content

BUG: Duplicated links are added using rte #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
yashvi2026 opened this issue Oct 24, 2024 · 3 comments
Closed
2 tasks done

BUG: Duplicated links are added using rte #6263

yashvi2026 opened this issue Oct 24, 2024 · 3 comments

Comments

@yashvi2026
Copy link

yashvi2026 commented Oct 24, 2024

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome

Reproducible demo link

https://codepen.io/Harshsne/pen/xxoOyXO

Describe the bug

How to reproduce the bug?

  1. add link to a word using rte, link component is added
  2. Now type something after the link component without space and select that word again add link to it .
  3. after adding it ,click outside the textbox.

What is the expected behavior?
Second Added link should be wrapped around the first link and the text.

What is the current behavior?
Two link component is added.

code
var url = window.prompt('Enter the URL to link to:');
rte.insertHTML(<a class="link" href=${url}>${rte.selection()}</a>);

edi11

Code of Conduct

  • I agree to follow this project's Code of Conduct
@yashvi2026 yashvi2026 changed the title BUG: Two link component is added suing rte BUG: Two link component is added using rte Oct 24, 2024
@yashvi2026 yashvi2026 changed the title BUG: Two link component is added using rte BUG: Duplicated links are added using rte Oct 24, 2024
@sirbeagle
Copy link
Contributor

So I've been playing around with this quite a bit and I can reproduce the error on the Codepen that @yashvi2026 provided. My steps to reproduce (most of the time) are very similar:

  1. Type two words with numerous spaces in between in a text box.
  2. Highlight the first word by double-clicking word or manually choose with mouse
  3. Use the custom RTE to add a link
  4. Click outside the box
  5. Double click back after the link in the existing text
  6. Highlight the word after the link and extend that highlight to include the first letter of the first link using a mouse
  7. Use RTE to add another link
  8. Click outside of the text box

However, I was unable to reproduce this in a dev environment. After lots of trial and error, I saw that the Codepen is using GrapesJS v0.22.1. I switched that to use v0.22.4 (the latest Codepen could find) and I could no longer reproduce it.

@yashvi2026 - if you upgrade the version in your Codepen (or wherever else you were seeing this) can you still reproduce the error?

@yashvi2026
Copy link
Author

Yes.After upgrading to latest version ,this issue doesnt occur.

@sirbeagle
Copy link
Contributor

Alight - the only bad part is we may never know what the fix ended up being.

@artf - I think we can close out this issue.

@artf artf closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants