Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relocateClass should not be called with resource paths #867

Open
oehme opened this issue May 11, 2023 · 0 comments
Open

relocateClass should not be called with resource paths #867

oehme opened this issue May 11, 2023 · 0 comments

Comments

@oehme
Copy link

oehme commented May 11, 2023

The following line should call relocateClass with just the file name, like in the if-statement above and take care of the META-INF/services prefix itself. The relocateClass method shouldn't have to deal with slashes.

https://github.com/johnrengelman/shadow/blob/9c5182d2d9c5f7141e4d2a525ec94d6111283cd9/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformer.groovy#L75

Noticed this while implementing my own relocator.
@oehme oehme changed the title relocateClass should not be called with resource names relocateClass should not be called with resource paths May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oehme