Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from poltergeist in capybara tests #1096

Closed
SandeepTuniki opened this issue Jul 11, 2023 · 2 comments
Closed

Move away from poltergeist in capybara tests #1096

SandeepTuniki opened this issue Jul 11, 2023 · 2 comments
Assignees
@shivgautam
Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@SandeepTuniki
Copy link
Contributor

SandeepTuniki commented Jul 11, 2023 •
edited
Loading

Issue noticed while fixing #853.

We're using poltergeist in many samples' acceptance tests. The gem is unmaintained since 2020 atleast, so we need to move away from it.

Some possible alternatives are mentioned in Capybara's home page - https://github.com/teamcapybara/capybara#drivers

Also, some of the tests don't need to rely on headless browser, since they don't have any UI interactions. We can replace them with simple HTTP client calls
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 11, 2023
@SandeepTuniki SandeepTuniki mentioned this issue Jul 14, 2023
Merged
@NivedhaSenthil NivedhaSenthil added type: cleanup An internal cleanup or hygiene concern. and removed samples Issues that are directly related to samples. labels Jul 31, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 31, 2023
@shivgautam shivgautam self-assigned this Oct 23, 2023
@shivgautam
Copy link
Contributor

This is completed.

@SandeepTuniki
Copy link
Contributor Author

fixed in #1190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivgautam shivgautam

Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NivedhaSenthil @SandeepTuniki @shivgautam