-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workload identity for prow #202
Comments
Merged #204 Binding: fejta@fejta3:~/src/gh/test-infra$ experiment/workload-identity/bind-service-accounts.sh oss-prow us-west1-a prow default gerrit [email protected]
+ gcloud iam service-accounts add-iam-policy-binding --project=oss-prow --role=roles/iam.workloadIdentityUser '--member=serviceAccount:oss-prow.svc.id.goog[default/gerrit]' [email protected]
Updated IAM policy for serviceAccount [[email protected]]. |
Well that failed miserably, apparently because I cannot follow instructions: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#enable_workload_identity_on_an_existing_cluster |
oss-test-infra/prow/prowjobs/GoogleCloudPlatform/oss-test-infra/gcp-oss-test-infra-config.yaml Lines 114 to 116 in 4a64286
now uses oss-test-infra/prow/prowjobs/GoogleCloudPlatform/oss-test-infra/gcp-oss-test-infra-config.yaml Line 124 in 4a64286
which authenticates as oss-test-infra/prow/serviceaccounts/GoogleCloudPlatform_testgrid_serviceaccounts.yaml Lines 5 to 6 in 4a64286
|
Now will migrate the prow updater to use workload identity:
|
We should stop sending this flag:
oss-test-infra/prow/cluster/cluster.yaml
Line 344 in bc1c6b9
We already define a service account:
oss-test-infra/prow/cluster/cluster.yaml
Line 335 in bc1c6b9
We should annotate it with GCP SA rights: https://github.com/kubernetes/test-infra/tree/master/experiment/workload-identity
If the flag is unset then it will use default creds:
https://github.com/kubernetes/test-infra/blob/master/prow/cmd/gerrit/main.go#L240
https://github.com/kubernetes/test-infra/blob/164c5e85105f85bb8fd8c181a085911a3d1010fd/pkg/io/opener.go#L57-L60
https://godoc.org/cloud.google.com/go/storage#hdr-Creating_a_Client
Work:
The text was updated successfully, but these errors were encountered: