diff --git a/mmv1/products/accessapproval/FolderSettings.yaml b/mmv1/products/accessapproval/FolderSettings.yaml index fdfea19cab66..7e91dcba39c2 100644 --- a/mmv1/products/accessapproval/FolderSettings.yaml +++ b/mmv1/products/accessapproval/FolderSettings.yaml @@ -44,14 +44,14 @@ examples: - name: 'folder_access_approval_full' primary_resource_id: 'folder_access_approval' vars: - folder_name: 'my-folder' + folder_name: 'folder-faaf' test_env_vars: org_id: 'ORG_ID' exclude_test: true - name: 'folder_access_approval_active_key_version' primary_resource_id: 'folder_access_approval' vars: - folder_name: 'my-folder' + folder_name: 'folder-faak' test_env_vars: org_id: 'ORG_ID' exclude_test: true diff --git a/mmv1/products/compute/FirewallPolicyAssociation.yaml b/mmv1/products/compute/FirewallPolicyAssociation.yaml index 9af2b6a4ca61..977141851147 100644 --- a/mmv1/products/compute/FirewallPolicyAssociation.yaml +++ b/mmv1/products/compute/FirewallPolicyAssociation.yaml @@ -51,7 +51,7 @@ examples: vars: policy_name: 'my-policy' association_name: 'my-association' - folder_name: 'my-folder' + folder_name: 'folder-fpa' test_env_vars: org_id: 'ORG_ID' exclude_test: true @@ -60,7 +60,7 @@ examples: vars: policy_name: 'my-policy' association_name: 'my-association' - folder_name: 'my-folder' + folder_name: 'folder-fpas' test_env_vars: org_id: 'ORG_ID' exclude_test: true diff --git a/mmv1/products/kms/AutokeyConfig.yaml b/mmv1/products/kms/AutokeyConfig.yaml index d5c54ee2fa53..fd428c40bd97 100644 --- a/mmv1/products/kms/AutokeyConfig.yaml +++ b/mmv1/products/kms/AutokeyConfig.yaml @@ -63,7 +63,7 @@ examples: # test depends upon google_project_service_identity service which is still in beta, so we need to keep test limited to beta min_version: 'beta' vars: - folder_name: 'my-folder' + folder_name: 'folder-cfg' key_project_name: 'key-proj' test_env_vars: org_id: 'ORG_ID' diff --git a/mmv1/products/kms/FolderKajPolicyConfig.yaml b/mmv1/products/kms/FolderKajPolicyConfig.yaml index 5c052436fdfe..d9fc99ae3bf8 100644 --- a/mmv1/products/kms/FolderKajPolicyConfig.yaml +++ b/mmv1/products/kms/FolderKajPolicyConfig.yaml @@ -57,7 +57,7 @@ examples: primary_resource_id: "example" min_version: 'beta' vars: - folder_name: 'my-folder' + folder_name: 'folder-kajc' test_env_vars: org_id: 'ORG_ID' billing_account: 'BILLING_ACCT' diff --git a/mmv1/products/kms/KeyHandle.yaml b/mmv1/products/kms/KeyHandle.yaml index bf76c3433755..1f51d933a2b7 100644 --- a/mmv1/products/kms/KeyHandle.yaml +++ b/mmv1/products/kms/KeyHandle.yaml @@ -57,7 +57,7 @@ examples: # test depends upon google_project_service_identity service which is still in beta, so we need to keep test limited to beta min_version: 'beta' vars: - folder_name: 'my-folder' + folder_name: 'folder-kh' key_project_name: 'key-proj' resource_project_name: 'res-proj' test_env_vars: diff --git a/mmv1/products/resourcemanager3/Capability.yaml b/mmv1/products/resourcemanager3/Capability.yaml index db4d6aba9f42..a85e647cc0c6 100644 --- a/mmv1/products/resourcemanager3/Capability.yaml +++ b/mmv1/products/resourcemanager3/Capability.yaml @@ -50,11 +50,11 @@ examples: - name: 'resource_manager_capability' primary_resource_id: 'capability' vars: - display_name: 'my-folder' + display_name: 'folder-cap' test_env_vars: org_id: "ORG_ID" external_providers: ["time"] - + exclude_test: true parameters: properties: diff --git a/mmv1/third_party/terraform/services/accessapproval/data_source_access_approval_folder_service_account_test.go b/mmv1/third_party/terraform/services/accessapproval/data_source_access_approval_folder_service_account_test.go index 4af0dc66ba87..27a706c13aec 100644 --- a/mmv1/third_party/terraform/services/accessapproval/data_source_access_approval_folder_service_account_test.go +++ b/mmv1/third_party/terraform/services/accessapproval/data_source_access_approval_folder_service_account_test.go @@ -38,7 +38,7 @@ func TestAccDataSourceAccessApprovalFolderServiceAccount_basic(t *testing.T) { func testAccDataSourceAccessApprovalFolderServiceAccount_basic(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "my_folder" { - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-aasa-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/accessapproval/resource_access_approval_folder_settings_test.go b/mmv1/third_party/terraform/services/accessapproval/resource_access_approval_folder_settings_test.go index c24eb6f568b2..d87f28d77494 100644 --- a/mmv1/third_party/terraform/services/accessapproval/resource_access_approval_folder_settings_test.go +++ b/mmv1/third_party/terraform/services/accessapproval/resource_access_approval_folder_settings_test.go @@ -65,7 +65,7 @@ func testAccAccessApprovalFolderSettings(t *testing.T) { func testAccAccessApprovalFolderSettings_full(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "my_folder" { - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-sfu-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } @@ -93,7 +93,7 @@ resource "google_folder_access_approval_settings" "folder_access_approval" { func testAccAccessApprovalFolderSettings_update(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "my_folder" { - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-sup-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } @@ -121,7 +121,7 @@ resource "google_folder_access_approval_settings" "folder_access_approval" { func testAccAccessApprovalFolderSettings_activeKeyVersion(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "my_folder" { - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-kv-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_firewall_policy_association_test.go b/mmv1/third_party/terraform/services/compute/resource_compute_firewall_policy_association_test.go index e3608db653b3..a3f6a3b6df87 100644 --- a/mmv1/third_party/terraform/services/compute/resource_compute_firewall_policy_association_test.go +++ b/mmv1/third_party/terraform/services/compute/resource_compute_firewall_policy_association_test.go @@ -38,7 +38,7 @@ func TestAccComputeFirewallPolicyAssociation_basic(t *testing.T) { func testAccComputeFirewallPolicyAssociation_basic(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "folder" { - display_name = "tf-test-folder-%{random_suffix}" + display_name = "tf-test-folder-bup-%{random_suffix}" parent = "%{org_name}" deletion_protection = false } @@ -94,7 +94,7 @@ func TestAccComputeFirewallPolicyAssociation_organization(t *testing.T) { func testAccComputeFirewallPolicyAssociation_organization(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "folder" { - display_name = "tf-test-my-folder-%{random_suffix}" + display_name = "tf-test-folder-fpau-%{random_suffix}" parent = "%{org_name}" deletion_protection = false } @@ -152,7 +152,7 @@ func TestAccComputeFirewallPolicyAssociation_swapover(t *testing.T) { func testAccComputeFirewallPolicyAssociation_swapover(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "folder" { - display_name = "tf-test-folder-%{random_suffix}" + display_name = "tf-test-folder-sou-%{random_suffix}" parent = "%{org_name}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_ha_policy_manual_leader_update_test.go b/mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_ha_policy_manual_leader_update_test.go index 952893dde6bb..625a6fb2964e 100644 --- a/mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_ha_policy_manual_leader_update_test.go +++ b/mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_ha_policy_manual_leader_update_test.go @@ -73,6 +73,7 @@ resource "google_compute_network_endpoint" "endpoint2" { instance = google_compute_instance.endpoint-instance2.name ip_address = google_compute_instance.endpoint-instance2.network_interface[0].network_ip + depends_on = [google_compute_network_endpoint.endpoint1] } data "google_compute_image" "my_image" { @@ -112,6 +113,7 @@ resource "google_compute_instance" "endpoint-instance2" { access_config { } } + depends_on = [google_compute_instance.endpoint-instance1] } resource "google_compute_network_endpoint_group" "neg" { @@ -145,11 +147,7 @@ resource "google_compute_region_backend_service" "default" { connection_draining_timeout_sec = 0 // Explicitly depend on the endpoints to prevent test flakes due to creating // the BackendService before the endpoints have been added to the NEG. - depends_on = [ - google_compute_network_endpoint_group.neg, - google_compute_network_endpoint.endpoint1, - google_compute_network_endpoint.endpoint2 - ] + depends_on = [google_compute_network_endpoint.endpoint2] } `, context) } diff --git a/mmv1/third_party/terraform/services/iam3/resource_iam_folders_policy_binding_test.go b/mmv1/third_party/terraform/services/iam3/resource_iam_folders_policy_binding_test.go index 6a4856956932..7e4373a4b156 100644 --- a/mmv1/third_party/terraform/services/iam3/resource_iam_folders_policy_binding_test.go +++ b/mmv1/third_party/terraform/services/iam3/resource_iam_folders_policy_binding_test.go @@ -57,7 +57,7 @@ resource "google_iam_principal_access_boundary_policy" "pab_policy" { } resource "google_folder" "folder" { - display_name = "test folder%{random_suffix}" + display_name = "tf-test-iam3-folder%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } @@ -92,7 +92,7 @@ resource "google_iam_principal_access_boundary_policy" "pab_policy" { } resource "google_folder" "folder" { - display_name = "test folder%{random_suffix}" + display_name = "tf-test-iam3-folder%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/kms/resource_kms_folder_kaj_policy_config_test.go.tmpl b/mmv1/third_party/terraform/services/kms/resource_kms_folder_kaj_policy_config_test.go.tmpl index 1e7e7c4048ae..8e86996d1e59 100644 --- a/mmv1/third_party/terraform/services/kms/resource_kms_folder_kaj_policy_config_test.go.tmpl +++ b/mmv1/third_party/terraform/services/kms/resource_kms_folder_kaj_policy_config_test.go.tmpl @@ -61,7 +61,7 @@ func testAccKMSFolderKajPolicyConfig_basic(context map[string]interface{}) strin # Create Folder in GCP Organization. resource "google_folder" "kaj_folder" { provider = google-beta - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-kaj-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } @@ -114,7 +114,7 @@ func testAccKMSFolderKajPolicyConfig_update(context map[string]interface{}) stri # Create Folder in GCP Organization. resource "google_folder" "kaj_folder" { provider = google-beta - display_name = "tf-test-my-folder%{random_suffix}" + display_name = "tf-test-folder-kaup-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/logging/resource_logging_folder_sink_test.go b/mmv1/third_party/terraform/services/logging/resource_logging_folder_sink_test.go index 1c82b4f80abf..0c6bd1fe1922 100644 --- a/mmv1/third_party/terraform/services/logging/resource_logging_folder_sink_test.go +++ b/mmv1/third_party/terraform/services/logging/resource_logging_folder_sink_test.go @@ -21,7 +21,7 @@ func TestAccLoggingFolderSink_basic(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-skb-" + acctest.RandString(t, 10) var sink logging.LogSink @@ -51,7 +51,7 @@ func TestAccLoggingFolderSink_described(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-sded-" + acctest.RandString(t, 10) acctest.VcrTest(t, resource.TestCase{ PreCheck: func() { acctest.AccTestPreCheck(t) }, @@ -75,7 +75,7 @@ func TestAccLoggingFolderSink_disabled(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-skdd-" + acctest.RandString(t, 10) acctest.VcrTest(t, resource.TestCase{ PreCheck: func() { acctest.AccTestPreCheck(t) }, @@ -99,7 +99,7 @@ func TestAccLoggingFolderSink_removeOptionals(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-skop-" + acctest.RandString(t, 10) acctest.VcrTest(t, resource.TestCase{ PreCheck: func() { acctest.AccTestPreCheck(t) }, @@ -132,7 +132,7 @@ func TestAccLoggingFolderSink_folderAcceptsFullFolderPath(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-path-" + acctest.RandString(t, 10) var sink logging.LogSink @@ -163,7 +163,7 @@ func TestAccLoggingFolderSink_update(t *testing.T) { sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) updatedBucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-skup-" + acctest.RandString(t, 10) parent := "organizations/" + org var sinkBefore, sinkAfter logging.LogSink @@ -209,7 +209,7 @@ func TestAccLoggingFolderSink_updateBigquerySink(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bqDatasetID := "tf_test_sink_" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-upbq-" + acctest.RandString(t, 10) acctest.VcrTest(t, resource.TestCase{ PreCheck: func() { acctest.AccTestPreCheck(t) }, @@ -242,7 +242,7 @@ func TestAccLoggingFolderSink_heredoc(t *testing.T) { org := envvar.GetTestOrgFromEnv(t) sinkName := "tf-test-sink-" + acctest.RandString(t, 10) bucketName := "tf-test-sink-bucket-" + acctest.RandString(t, 10) - folderName := "tf-test-folder-" + acctest.RandString(t, 10) + folderName := "tf-test-folder-skhd-" + acctest.RandString(t, 10) var sink logging.LogSink diff --git a/mmv1/third_party/terraform/services/resourcemanager/resource_folder_service_identity_test.go.tmpl b/mmv1/third_party/terraform/services/resourcemanager/resource_folder_service_identity_test.go.tmpl index 531f7b1b05ca..e2073df44189 100644 --- a/mmv1/third_party/terraform/services/resourcemanager/resource_folder_service_identity_test.go.tmpl +++ b/mmv1/third_party/terraform/services/resourcemanager/resource_folder_service_identity_test.go.tmpl @@ -53,7 +53,7 @@ func testGoogleFolderServiceIdentity_basic(context map[string]interface{}) strin return acctest.Nprintf(` resource "google_folder" "folder" { parent = "organizations/%{org_id}" - display_name = "test-folder-%{random_suffix}" + display_name = "tf-test-folder-%{random_suffix}" deletion_protection = false } diff --git a/mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go b/mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go index 1dad4e039323..e7b1472fbe59 100644 --- a/mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go +++ b/mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go @@ -11,6 +11,8 @@ import ( ) func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t *testing.T) { + // The test fails as the folder with a configured capability fails to be deleted. + acctest.SkipIfVcr(t) t.Parallel() context := map[string]interface{}{ @@ -52,7 +54,7 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t * func testAccResourceManagerCapability_resourceManagerCapabilityExample_basic(context map[string]interface{}) string { return acctest.Nprintf(` resource "google_folder" "folder" { - display_name = "my-folder%{random_suffix}" + display_name = "tf-test-folder-cpup-%{random_suffix}" parent = "organizations/%{org_id}" deletion_protection = false }