Allow not fully documented methods #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In out system we are gradually documenting everything, so not every method is fully documented.
Its valid raml to have
```yaml
/some-resource:
put:
get:
```
This means the method is accepted, but there is no further documentation.
The current implementation does not allow this, since the value of the `put` key will be `null`.
Allows the lib to match things like:
```
/v2:
/account/avatar/{id}:
get:
```
by looking ahead not just for current "part" but entire left over string
Needs to be improved to search for all possible matches.
Used the wrong function, replaced with strstr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our system we are gradually documenting everything, so not every method is fully documented.
Its valid raml to have
This means the method is accepted, but there is no further documentation.
The current implementation does not allow this, since the value of the
putkey will benull.Is this accepted behaviour? if so i'll write some tests for it.