fix unit tests warnings

arturcic · arturcic · commit 2319e7a97bcb · 2022-05-26T17:59:42.000+02:00
diff --git a/src/GitVersion.MsBuild.Tests/Tasks/GenerateGitVersionInformationTest.cs b/src/GitVersion.MsBuild.Tests/Tasks/GenerateGitVersionInformationTest.cs
@@ -204,7 +204,7 @@ private static void AddGenerateGitVersionInformationTask(ProjectCreator project,
         project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)
             .Property("GenerateAssemblyInfo", "false")
             .Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")
-            .Task(taskName, parameters: new Dictionary<string, string>
+            .Task(taskName, parameters: new Dictionary<string, string?>
             {
                 { "SolutionDirectory", "$(MSBuildProjectDirectory)" },
                 { "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" },
diff --git a/src/GitVersion.MsBuild.Tests/Tasks/GetVersionTaskTests.cs b/src/GitVersion.MsBuild.Tests/Tasks/GetVersionTaskTests.cs
@@ -104,7 +104,7 @@ private static void AddGetVersionTask(ProjectCreator project, string targetToRun
         project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)
             .Property("GenerateAssemblyInfo", "false")
             .Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")
-            .Task(taskName, parameters: new Dictionary<string, string>
+            .Task(taskName, parameters: new Dictionary<string, string?>
             {
                 { "SolutionDirectory", "$(MSBuildProjectDirectory)" },
                 { "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" }
diff --git a/src/GitVersion.MsBuild.Tests/Tasks/UpdateAssemblyInfoTaskTest.cs b/src/GitVersion.MsBuild.Tests/Tasks/UpdateAssemblyInfoTaskTest.cs
@@ -171,7 +171,7 @@ private static void AddUpdateAssemblyInfoTask(ProjectCreator project, string tar
         project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)
             .Property("GenerateAssemblyInfo", "false")
             .Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")
-            .Task(taskName, parameters: new Dictionary<string, string>
+            .Task(taskName, parameters: new Dictionary<string, string?>
             {
                 { "SolutionDirectory", "$(MSBuildProjectDirectory)" },
                 { "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" },
diff --git a/src/GitVersion.MsBuild.Tests/Tasks/WriteVersionInfoTest.cs b/src/GitVersion.MsBuild.Tests/Tasks/WriteVersionInfoTest.cs
@@ -128,7 +128,7 @@ private static void AddWriteVersionInfoToBuildLogTask(ProjectCreator project, st
         project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)
             .Property("GenerateAssemblyInfo", "false")
             .Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")
-            .Task(taskName, parameters: new Dictionary<string, string>
+            .Task(taskName, parameters: new Dictionary<string, string?>
             {
                 { "SolutionDirectory", "$(MSBuildProjectDirectory)" },
                 { "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" }

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ private static void AddGenerateGitVersionInformationTask(ProjectCreator project,`
`204`	`204`	`project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)`
`205`	`205`	`.Property("GenerateAssemblyInfo", "false")`
`206`	`206`	`.Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")`
`207`		`- .Task(taskName, parameters: new Dictionary<string, string>`
	`207`	`+ .Task(taskName, parameters: new Dictionary<string, string?>`
`208`	`208`	`{`
`209`	`209`	`{ "SolutionDirectory", "$(MSBuildProjectDirectory)" },`
`210`	`210`	`{ "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" },`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ private static void AddGetVersionTask(ProjectCreator project, string targetToRun`
`104`	`104`	`project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)`
`105`	`105`	`.Property("GenerateAssemblyInfo", "false")`
`106`	`106`	`.Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")`
`107`		`- .Task(taskName, parameters: new Dictionary<string, string>`
	`107`	`+ .Task(taskName, parameters: new Dictionary<string, string?>`
`108`	`108`	`{`
`109`	`109`	`{ "SolutionDirectory", "$(MSBuildProjectDirectory)" },`
`110`	`110`	`{ "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" }`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ private static void AddUpdateAssemblyInfoTask(ProjectCreator project, string tar`
`171`	`171`	`project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)`
`172`	`172`	`.Property("GenerateAssemblyInfo", "false")`
`173`	`173`	`.Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")`
`174`		`- .Task(taskName, parameters: new Dictionary<string, string>`
	`174`	`+ .Task(taskName, parameters: new Dictionary<string, string?>`
`175`	`175`	`{`
`176`	`176`	`{ "SolutionDirectory", "$(MSBuildProjectDirectory)" },`
`177`	`177`	`{ "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" },`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ private static void AddWriteVersionInfoToBuildLogTask(ProjectCreator project, st`
`128`	`128`	`project.UsingTaskAssemblyFile(taskName, assemblyFileLocation)`
`129`	`129`	`.Property("GenerateAssemblyInfo", "false")`
`130`	`130`	`.Target(targetToRun, beforeTargets: "CoreCompile;GetAssemblyVersion;GenerateNuspec")`
`131`		`- .Task(taskName, parameters: new Dictionary<string, string>`
	`131`	`+ .Task(taskName, parameters: new Dictionary<string, string?>`
`132`	`132`	`{`
`133`	`133`	`{ "SolutionDirectory", "$(MSBuildProjectDirectory)" },`
`134`	`134`	`{ "VersionFile", "$(MSBuildProjectDirectory)/gitversion.json" }`