fix sonar complaints

andreybavt · andreybavt · commit 2db5365e129d · 2023-11-03T19:23:17.000+01:00
diff --git a/giskard/core/model_validation.py b/giskard/core/model_validation.py
@@ -245,7 +245,7 @@ def validate_classification_threshold_label(
         )
 
     if classification_threshold is not None:
-        if classification_threshold != 0.5 and len(classification_labels) != 2:
+        if not np.isclose(classification_threshold, 0.5, rtol=1e-09, atol=1e-09) and len(classification_labels) != 2:
             raise ValueError(
                 f"Invalid classification_threshold parameter: {classification_threshold} value is applicable "
                 f"only for binary classification. "

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ def validate_classification_threshold_label(`
`245`	`245`	`)`
`246`	`246`
`247`	`247`	`if classification_threshold is not None:`
`248`		`- if classification_threshold != 0.5 and len(classification_labels) != 2:`
	`248`	`+ if not np.isclose(classification_threshold, 0.5, rtol=1e-09, atol=1e-09) and len(classification_labels) != 2:`
`249`	`249`	`raise ValueError(`
`250`	`250`	`f"Invalid classification_threshold parameter: {classification_threshold} value is applicable "`
`251`	`251`	`f"only for binary classification. "`