Skip to content

Commit b156fdd

Browse files
authored
Merge pull request #242 from GetStream/patches/125.3
Fix for m125.3
2 parents e46dbd8 + b265ded commit b156fdd

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

stream-webrtc-android/api/stream-webrtc-android.api

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2199,6 +2199,7 @@ public class org/webrtc/audio/JavaAudioDeviceModule$Builder {
21992199
public fun createAudioDeviceModule ()Lorg/webrtc/audio/JavaAudioDeviceModule;
22002200
public fun setAudioAttributes (Landroid/media/AudioAttributes;)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;
22012201
public fun setAudioFormat (I)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;
2202+
public fun setAudioRecordDataCallback (Lorg/webrtc/audio/AudioRecordDataCallback;)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;
22022203
public fun setAudioRecordErrorCallback (Lorg/webrtc/audio/JavaAudioDeviceModule$AudioRecordErrorCallback;)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;
22032204
public fun setAudioRecordStateCallback (Lorg/webrtc/audio/JavaAudioDeviceModule$AudioRecordStateCallback;)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;
22042205
public fun setAudioSource (I)Lorg/webrtc/audio/JavaAudioDeviceModule$Builder;

stream-webrtc-android/src/main/java/org/webrtc/SoftwareVideoDecoderFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@ public VideoCodecInfo[] getSupportedCodecs() {
5050
private static native long nativeCreateDecoder(long factory, VideoCodecInfo videoCodecInfo);
5151

5252
private static native List<VideoCodecInfo> nativeGetSupportedCodecs(long factory);
53-
}
53+
}

stream-webrtc-android/src/main/java/org/webrtc/voiceengine/WebRtcAudioRecord.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public void run() {
170170
// at index 0.
171171
byte[] data = Arrays.copyOf(byteBuffer.array(), byteBuffer.capacity());
172172
audioSamplesReadyCallback.onWebRtcAudioRecordSamplesReady(
173-
new AudioSamples(audioRecord, data));
173+
new AudioSamples(audioRecord, data));
174174
}
175175
} else {
176176
String errorMessage = "AudioRecord.read failed: " + bytesRead;
@@ -253,7 +253,7 @@ private int initRecording(int sampleRate, int channels) {
253253
// Note that this size doesn't guarantee a smooth recording under load.
254254
final int channelConfig = channelCountToConfiguration(channels);
255255
int minBufferSize =
256-
AudioRecord.getMinBufferSize(sampleRate, channelConfig, AudioFormat.ENCODING_PCM_16BIT);
256+
AudioRecord.getMinBufferSize(sampleRate, channelConfig, AudioFormat.ENCODING_PCM_16BIT);
257257
if (minBufferSize == AudioRecord.ERROR || minBufferSize == AudioRecord.ERROR_BAD_VALUE) {
258258
reportWebRtcAudioRecordInitError("AudioRecord.getMinBufferSize failed: " + minBufferSize);
259259
return -1;
@@ -267,7 +267,7 @@ private int initRecording(int sampleRate, int channels) {
267267
Logging.d(TAG, "bufferSizeInBytes: " + bufferSizeInBytes);
268268
try {
269269
audioRecord = new AudioRecord(audioSource, sampleRate, channelConfig,
270-
AudioFormat.ENCODING_PCM_16BIT, bufferSizeInBytes);
270+
AudioFormat.ENCODING_PCM_16BIT, bufferSizeInBytes);
271271
} catch (IllegalArgumentException e) {
272272
reportWebRtcAudioRecordInitError("AudioRecord ctor error: " + e.getMessage());
273273
releaseAudioResources();
@@ -294,13 +294,13 @@ private boolean startRecording() {
294294
audioRecord.startRecording();
295295
} catch (IllegalStateException e) {
296296
reportWebRtcAudioRecordStartError(AudioRecordStartErrorCode.AUDIO_RECORD_START_EXCEPTION,
297-
"AudioRecord.startRecording failed: " + e.getMessage());
297+
"AudioRecord.startRecording failed: " + e.getMessage());
298298
return false;
299299
}
300300
if (audioRecord.getRecordingState() != AudioRecord.RECORDSTATE_RECORDING) {
301301
reportWebRtcAudioRecordStartError(
302-
AudioRecordStartErrorCode.AUDIO_RECORD_START_STATE_MISMATCH,
303-
"AudioRecord.startRecording failed - incorrect state :"
302+
AudioRecordStartErrorCode.AUDIO_RECORD_START_STATE_MISMATCH,
303+
"AudioRecord.startRecording failed - incorrect state :"
304304
+ audioRecord.getRecordingState());
305305
return false;
306306
}
@@ -327,16 +327,16 @@ private boolean stopRecording() {
327327

328328
private void logMainParameters() {
329329
Logging.d(TAG, "AudioRecord: "
330-
+ "session ID: " + audioRecord.getAudioSessionId() + ", "
331-
+ "channels: " + audioRecord.getChannelCount() + ", "
332-
+ "sample rate: " + audioRecord.getSampleRate());
330+
+ "session ID: " + audioRecord.getAudioSessionId() + ", "
331+
+ "channels: " + audioRecord.getChannelCount() + ", "
332+
+ "sample rate: " + audioRecord.getSampleRate());
333333
}
334334

335335
private void logMainParametersExtended() {
336336
if (Build.VERSION.SDK_INT >= 23) {
337337
Logging.d(TAG, "AudioRecord: "
338-
// The frame count of the native AudioRecord buffer.
339-
+ "buffer size in frames: " + audioRecord.getBufferSizeInFrames());
338+
// The frame count of the native AudioRecord buffer.
339+
+ "buffer size in frames: " + audioRecord.getBufferSizeInFrames());
340340
}
341341
}
342342

@@ -358,7 +358,7 @@ private int channelCountToConfiguration(int channels) {
358358
@SuppressWarnings("NoSynchronizedMethodCheck")
359359
public static synchronized void setAudioSource(int source) {
360360
Logging.w(TAG, "Audio source is changed from: " + audioSource
361-
+ " to " + source);
361+
+ " to " + source);
362362
audioSource = source;
363363
}
364364

@@ -391,7 +391,7 @@ private void reportWebRtcAudioRecordInitError(String errorMessage) {
391391
}
392392

393393
private void reportWebRtcAudioRecordStartError(
394-
AudioRecordStartErrorCode errorCode, String errorMessage) {
394+
AudioRecordStartErrorCode errorCode, String errorMessage) {
395395
Logging.e(TAG, "Start recording error: " + errorCode + ". " + errorMessage);
396396
WebRtcAudioUtils.logAudioState(TAG);
397397
if (errorCallback != null) {
@@ -406,4 +406,4 @@ private void reportWebRtcAudioRecordError(String errorMessage) {
406406
errorCallback.onWebRtcAudioRecordError(errorMessage);
407407
}
408408
}
409-
}
409+
}

0 commit comments

Comments
 (0)