From adc966881198d8a5b47a1d00eee35273dd6ba962 Mon Sep 17 00:00:00 2001 From: Sacha Arbonel Date: Wed, 23 Feb 2022 18:15:39 -0400 Subject: [PATCH 1/2] fix timeout error --- .../lib/src/core/error/stream_feeds_error.dart | 5 ++--- .../stream_feed/test/stream_feeds_error_test.dart | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/packages/stream_feed/lib/src/core/error/stream_feeds_error.dart b/packages/stream_feed/lib/src/core/error/stream_feeds_error.dart index 8fa64e6e8..209319fa5 100644 --- a/packages/stream_feed/lib/src/core/error/stream_feeds_error.dart +++ b/packages/stream_feed/lib/src/core/error/stream_feeds_error.dart @@ -42,9 +42,8 @@ class StreamFeedsNetworkError extends StreamFeedsError { factory StreamFeedsNetworkError.fromDioError(DioError error) { final response = error.response; ErrorResponse? errorResponse; - final data = json.decode(response?.data); - if (data != null) { - errorResponse = ErrorResponse.fromJson(data); + if (response?.data != null) { + errorResponse = ErrorResponse.fromJson(json.decode(response!.data)); } return StreamFeedsNetworkError.raw( code: errorResponse?.code ?? -1, diff --git a/packages/stream_feed/test/stream_feeds_error_test.dart b/packages/stream_feed/test/stream_feeds_error_test.dart index e900a514e..536fe9b99 100644 --- a/packages/stream_feed/test/stream_feeds_error_test.dart +++ b/packages/stream_feed/test/stream_feeds_error_test.dart @@ -17,6 +17,21 @@ void main() { expect(error.message, message); }); + test('time out', () { + const message = 'Connecting timed out [0ms]'; + final options = RequestOptions(path: 'test-path'); + + + final dioError = DioError( + requestOptions: options, + error: 'Connecting timed out [${options.connectTimeout}ms]', + type: DioErrorType.connectTimeout, + ); + final error = StreamFeedsNetworkError.fromDioError(dioError); + expect(error, isNotNull); + expect(error.message, message); + }); + test('.fromDioError', () { const code = 333; const statusCode = 666; From 96aaa18255b6a02847d9eb50659bdea1fc269a68 Mon Sep 17 00:00:00 2001 From: Sacha Arbonel Date: Thu, 24 Feb 2022 16:41:45 -0400 Subject: [PATCH 2/2] format --- packages/stream_feed/test/stream_feeds_error_test.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/stream_feed/test/stream_feeds_error_test.dart b/packages/stream_feed/test/stream_feeds_error_test.dart index 536fe9b99..fa593d64c 100644 --- a/packages/stream_feed/test/stream_feeds_error_test.dart +++ b/packages/stream_feed/test/stream_feeds_error_test.dart @@ -21,7 +21,6 @@ void main() { const message = 'Connecting timed out [0ms]'; final options = RequestOptions(path: 'test-path'); - final dioError = DioError( requestOptions: options, error: 'Connecting timed out [${options.connectTimeout}ms]',