Skip to content

Commit eb444b0

Browse files
authored
docs: remove review notes from the documentation (#1850)
1 parent 8023d0a commit eb444b0

File tree

12 files changed

+1
-233
lines changed

12 files changed

+1
-233
lines changed

docusaurus/docs/React/_docusaurus-components/ReviewNote.jsx

Lines changed: 0 additions & 76 deletions
This file was deleted.

docusaurus/docs/React/basics/getting-started.mdx

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ sidebar_position: 2
44
title: Getting Started
55
---
66

7-
import ReviewNote from '../_docusaurus-components/ReviewNote';
8-
97
This section provides a high level overview of the library setup, core components, and how they fit together. It's a great
108
starting point and you can follow along in your code editor. For a complete, step-by-step guide in terms setting up a React
119
project or instructions on creating specific files, see our [React Chat tutorial](https://getstream.io/chat/react-chat/tutorial/).
@@ -84,17 +82,6 @@ The defaults include:
8482
- `gaming`
8583
- `commerce`
8684

87-
<ReviewNote
88-
id='ab86a784-22f9-11ed-936e-a4bb6d26ac2f'
89-
>
90-
Failing to provide explanation why in the first place should user of the SDK interact with the channel object
91-
directly.
92-
Provide examples of scenarios when a channel object would be needed.
93-
Missing the mention, that ChannelList - if used - loads channel data from the API and thus it integrator does not need
94-
to create channels
95-
Proposing to add recommendation to create channels from the backend
96-
</ReviewNote>
97-
9885
:::note
9986
You can also create [custom channel types](https://getstream.io/chat/docs/react/channel_features/#creating-a-channel-type)
10087
and define your own permission sets.
@@ -120,12 +107,6 @@ const channel = client.channel('messaging', {
120107
Now that we have a client instance, a connected user, and a channel, it's time to look at the core components involved in building
121108
a fully functioning chat application.
122109

123-
<ReviewNote
124-
id='dcfe3c22-2304-11ed-83ef-a4bb6d26ac2f'
125-
>
126-
Add visualisation - wireframe - to demonstrate the main components in the UI
127-
</ReviewNote>
128-
129110
### Chat
130111

131112
The [`Chat`](../components/core-components/chat.mdx) component is a React Context provider that wraps the entire Stream Chat application. It provides the [`ChatContext`](../components/contexts/chat-context.mdx)
@@ -199,15 +180,6 @@ In addition to the above referenced UI components, client instantiation, and use
199180
Remember our [Theming](../guides/theming/overview.mdx) and [Customizing Components](../guides/customization/overview.mdx) sections in our guides. They offer you a lot of flexibility when adopting our SDK.
200181
:::
201182

202-
<ReviewNote
203-
id='179e58f8-22fb-11ed-909b-a4bb6d26ac2f'
204-
>
205-
The filters variable should actually include members key:
206-
<CodeBlock>{'const filters = {type: "messaging", members: {$in: [userId]}};'}</CodeBlock>
207-
That means that we should explain how the userId gets there in a real life application. For a real-life example too
208-
soon here?
209-
</ReviewNote>
210-
211183
```tsx
212184
import React, { useEffect, useState } from 'react';
213185
import { StreamChat } from 'stream-chat';

docusaurus/docs/React/components/contexts/chat-context.mdx

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ sidebar_position: 1
44
title: ChatContext
55
---
66

7-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
8-
97
The `ChatContext` is exposed by the [`Chat`](../core-components/chat.mdx) component. Since `Chat` wraps the entire chat application, all other components in the library
108
have access to the values stored in this context. You can access the context values by calling the `useChatContext` custom hook.
119

@@ -35,13 +33,6 @@ The currently active channel, which populates the [`Channel`](../core-components
3533
| ------- |
3634
| Channel |
3735

38-
39-
<ReviewNote
40-
id='8f87022a-2305-11ed-9971-a4bb6d26ac2f'
41-
>
42-
This applies only to theme V1. We should include deprecation notice.
43-
</ReviewNote>
44-
4536
### closeMobileNav
4637

4738
The function to close mobile navigation.
@@ -83,12 +74,6 @@ An array of users that have been muted by the connected user.
8374
| ------ |
8475
| Mute[] |
8576

86-
<ReviewNote
87-
id='db6b3990-2305-11ed-bcfc-a4bb6d26ac2f'
88-
>
89-
This applies only to theme V1. We should include deprecation notice.
90-
</ReviewNote>
91-
9277
### navOpen
9378

9479
When the screen width is at a mobile breakpoint, whether the mobile navigation menu is open.
@@ -97,12 +82,6 @@ When the screen width is at a mobile breakpoint, whether the mobile navigation m
9782
|---------|---------|
9883
| boolean | true |
9984

100-
<ReviewNote
101-
id='eeaf7eb2-2305-11ed-9285-a4bb6d26ac2f'
102-
>
103-
This applies only to theme V1. We should include deprecation notice.
104-
</ReviewNote>
105-
10685
### openMobileNav
10786

10887
The function to open mobile navigation.
@@ -120,12 +99,6 @@ You can override the default behavior by pulling it from context and then utiliz
12099
|----------|
121100
| function |
122101

123-
<ReviewNote
124-
id='57bc33a6-2369-11ed-aefd-a4bb6d26ac2f'
125-
>
126-
Should we remove this value from the chat context?
127-
</ReviewNote>
128-
129102
### theme
130103

131104
Deprecated and to be removed in a future major release. Use the `customStyles` prop to adjust CSS variables and [customize the theme](../../guides/theming/css-and-theming.mdx#css-variables) of your app.
@@ -134,12 +107,6 @@ Deprecated and to be removed in a future major release. Use the `customStyles` p
134107
| ----- |
135108
| Theme |
136109

137-
<ReviewNote
138-
id='df7331b2-243d-11ed-8076-a4bb6d26ac2f'
139-
>
140-
Proposing to add information about which release has introduced a given prop/value
141-
</ReviewNote>
142-
143110
### themeVersion
144111

145112
Stream chat theme version 2 has been introduced with the release of stream-chat-react v10.0.0. This flag is used internally by some UI components of the SDK and the integrators shouldn't need to use it. The value is extracted from a CSS variable `--str-chat__theme-version`. You can set it to values `'1'` or `'2'` in your stylesheets and import the corresponding v2 stylesheet from `stream-chat-react/dist`. Find out more about benefits that the theme version 2 brings to the integrators with [the theming guide](../../guides/theming/css-and-theming.mdx).

docusaurus/docs/React/components/core-components/channel-list.mdx

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ title: ChannelList
66
import CodeBlock from '@theme/CodeBlock';
77

88
import GHComponentLink from '../../_docusaurus-components/GHComponentLink';
9-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
109

1110

1211
The `ChannelList` component queries an array of `channel` objects from the Stream Chat API and displays as a customizable list
@@ -23,14 +22,6 @@ The `ChannelList` component also comes pre-built with navigation functionality.
2322

2423
## Basic Usage
2524

26-
<ReviewNote
27-
id='a0523cee-2375-11ed-8530-a4bb6d26ac2f'
28-
>
29-
Proposing to make filters mandatory as per the JS docs requirement: At a minimum, the filter should include:
30-
<CodeBlock>{`{members: { $in: [userID] }}`}</CodeBlock>
31-
It is confusing to newcomers that the channels query fails due to this missing param
32-
</ReviewNote>
33-
3425
The `ChannelList` does not have any required props, but in order to refine channel query results we recommend providing
3526
values for [`filters`](#filters), [`sort`](#sort) and [`options`](#options).
3627

@@ -373,13 +364,6 @@ Function to override the default behavior when rendering channels, so this funct
373364
|----------|
374365
| function |
375366

376-
<ReviewNote
377-
id='6bd7d78e-2542-11ed-a44c-a4bb6d26ac2f'
378-
>
379-
Missing example use case to better understand the purpose. The default `List` component does not make use of the
380-
loadedChannels prop
381-
</ReviewNote>
382-
383367
### sendChannelsToList
384368

385369
If true, sends the list's currently loaded channels to the `List` component as the `loadedChannels` prop.

docusaurus/docs/React/components/core-components/chat.mdx

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ sidebar_position: 2
44
title: Chat
55
---
66

7-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
8-
97
The `Chat` component is a React Context provider that wraps the entire Stream Chat application. It provides the [`ChatContext`](../contexts/chat-context.mdx)
108
to its children, which includes the `StreamChat` client instance. All other components within the library must be nested as children
119
of `Chat` to maintain proper functionality.
@@ -56,12 +54,6 @@ for implementation assistance.
5654
| ------ |
5755
| object |
5856

59-
<ReviewNote
60-
id='d24641be-2302-11ed-a4fd-a4bb6d26ac2f'
61-
>
62-
This applies only to theme V1. We should include deprecation notice.
63-
</ReviewNote>
64-
6557
### customStyles
6658

6759
Object containing custom styles to override the default CSS variables. See [CSS and Theming](../../guides/theming/css-and-theming.mdx)
@@ -71,12 +63,6 @@ for implementation assistance.
7163
| ------ |
7264
| object |
7365

74-
<ReviewNote
75-
id='045d0e58-2303-11ed-add3-a4bb6d26ac2f'
76-
>
77-
This applies only to theme V1. We should include deprecation notice.
78-
</ReviewNote>
79-
8066
### darkMode
8167

8268
If true, toggles the CSS variables to the default dark mode color palette.
@@ -115,12 +101,6 @@ const i18nInstance = new Streami18n({
115101
| ------ |
116102
| object |
117103
118-
<ReviewNote
119-
id='1183a05a-2304-11ed-b48a-a4bb6d26ac2f'
120-
>
121-
This applies only to theme V1. We should include deprecation notice.
122-
</ReviewNote>
123-
124104
### initialNavOpen
125105
126106
When the screen width is at a mobile breakpoint, whether or not the mobile navigation menu is open.
@@ -129,12 +109,6 @@ When the screen width is at a mobile breakpoint, whether or not the mobile navig
129109
| ------- | ------- |
130110
| boolean | true |
131111
132-
<ReviewNote
133-
id='4ee6062c-2304-11ed-aee7-a4bb6d26ac2f'
134-
>
135-
Should we remove this prop?
136-
</ReviewNote>
137-
138112
### theme
139113
140114
Deprecated and to be removed in a future major release. Use the `customStyles` prop to adjust CSS variables and [customize the theme](../../guides/theming/css-and-theming.mdx#css-variables) of your app.

docusaurus/docs/React/components/core-components/message-list.mdx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ title: MessageList
55
---
66

77
import GHComponentLink from '../../_docusaurus-components/GHComponentLink';
8-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
98

109
import MessageActionsBoxWithCustomAction from '../../assets/message-actions-box-custom-actions.png';
1110

@@ -285,11 +284,6 @@ Whether the list has more items to load.
285284
| ------- | ------------------------------------------------------------------------------------ |
286285
| boolean | [ChannelStateContextValue['hasMore']](../contexts/channel-state-context.mdx#hasmore) |
287286

288-
<ReviewNote id='6af16f24-2849-11ed-a3b5-a4bb6d26ac2f'>
289-
This prop needs a link to an example or a demonstration of use of header component and its
290-
positioning.
291-
</ReviewNote>
292-
293287
### headerPosition
294288

295289
Position to render the `HeaderComponent` in the list.
@@ -414,10 +408,6 @@ Custom action handler function to run on click of user avatar.
414408

415409
Custom action handler function to run on hover of user avatar.
416410

417-
<ReviewNote id='c6f3972e-2854-11ed-9abc-a4bb6d26ac2f'>
418-
Shouldn't the event type be MouseEvent?
419-
</ReviewNote>
420-
421411
| Type |
422412
| ----------------------------------------------------- |
423413
| (event: React.BaseSyntheticEvent, user: User) => void |

docusaurus/docs/React/components/core-components/thread.mdx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ sidebar_position: 7
44
title: Thread
55
---
66

7-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
8-
97
The `Thread` component renders a list of replies tied to a single parent message in a channel's main message list.
108
A `Thread` maintains its own state and renders its own `MessageList` and `MessageInput` components. Each piece of
119
rendered UI can be overridden with custom components either drawn from the `ComponentContext` or supplied via props.
@@ -172,12 +170,6 @@ Controls injection of <GHComponentLink text='DateSeparator' path='/DateSeparator
172170
|---------|---------|
173171
| boolean | false |
174172

175-
<ReviewNote
176-
id='787aad50-2866-11ed-88c5-a4bb6d26ac2f'
177-
>
178-
Proposing the <pre>fullWidth</pre> prop to be deprecated / removed. The container width should be handled by CSS.
179-
</ReviewNote>
180-
181173
### fullWidth
182174

183175
If true, displays the thread at 100% width of its parent container, useful for mobile styling.

docusaurus/docs/React/components/core-components/virtualized-list.mdx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ title: VirtualizedMessageList
55
---
66

77
import GHComponentLink from '../../_docusaurus-components/GHComponentLink';
8-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
98

109
The `VirtualizedMessageList` component renders a scrollable list of messages. It differs from the standard `MessageList`
1110
in that it handles UI virtualization by default. Virtualization is a technique used to emulate large lists of elements by
@@ -224,12 +223,6 @@ If true, group messages belonging to the same user, otherwise show each message
224223
|---------|---------|
225224
| boolean | false |
226225

227-
<ReviewNote
228-
id='5f3a9958-2849-11ed-84d3-a4bb6d26ac2f'
229-
>
230-
This flag does not work. Can we deprecate it? See the <a href='https://github.com/GetStream/stream-chat-react/issues/1729' target='_blank'>GH issue</a>.
231-
</ReviewNote>
232-
233226
### separateGiphyPreview
234227

235228
If true, the Giphy preview will render as a separate component above the `MessageInput`, rather than inline with the other messages in the list.

docusaurus/docs/React/components/message-components/attachment.mdx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ title: Attachments
55
---
66

77
import GHComponentLink from '../../_docusaurus-components/GHComponentLink';
8-
import ReviewNote from '../../_docusaurus-components/ReviewNote';
98
import ImageSizingScreenshot1 from '../../assets/ImageSizing1.png';
109
import ImageSizingScreenshot2 from '../../assets/ImageSizing2.png';
1110
import ImageSizingScreenshot3 from '../../assets/ImageSizing3.png';
@@ -177,11 +176,6 @@ The handler function to call when an action is performed on an attachment, examp
177176
| ----------------------------------------------------------------------------------------------------- |
178177
| (dataOrName?: string \| FormData, value?: string, event?: React.BaseSyntheticEvent) => Promise<void\> |
179178
180-
<ReviewNote author='Martin Cupela' id='04803878-3362-11ed-8912-a4bb6d26ac2f'>
181-
What are attachment actions, what is their use case / recipes? Missing concept explanation. It
182-
would be nice to have a link to a doc explaining these.
183-
</ReviewNote>
184-
185179
### AttachmentActions
186180
187181
Custom UI component for displaying attachment actions.

0 commit comments

Comments
 (0)