Installation failure leaves backup directories behind (no cleanup on error)

[daesdev]

⸻

Description

When the installation fails during the “Backup Existing Configs” step, the installer creates backup directories but does not clean them up after the failure.

This leaves orphaned backup folders in the user’s home directory, which can create silent clutter and confusion for the user.

⸻

Environment
• OS: macOS
• Shell: zsh
• Terminal: Ghostty
• Window manager: tmux
• Neovim configuration: enabled

⸻

Steps to Reproduce
1. Run the gentleman.dots installer.
2. Go through the setup steps:
• OS: macOS
• Terminal: Ghostty
• Install fonts: Yes
• Shell: zsh
• Window manager: tmux
• Neovim config: Yes
3. Let the installation fail during the Backup Existing Configs step.
4. Check the home directory.

⸻

Result

Backup folders remain even though the installation fails.

Example:

.gentleman-backup-2024-09-122040
.gentleman-backup-2024-09-122835

These directories appear to be created during the backup step but are not removed when the installation aborts.

[Alan-TheGentleman]

Bug legítimo. Cuando el installer falla, los directorios de backup quedan huérfanos. Aprobado.

El fix correcto es un defer o equivalente que limpie los backups si la instalación aborta. Si alguien quiere abrir un PR enfocado solo en esto, bienvenido.