Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require assembly parameter for genomic_to_tx_segment #390

Closed
jarbesfeld opened this issue Jan 3, 2025 · 0 comments · Fixed by #391
Closed

Require assembly parameter for genomic_to_tx_segment #390

jarbesfeld opened this issue Jan 3, 2025 · 0 comments · Fixed by #391
Assignees
@jarbesfeld
Labels
enhancement New feature or request priority:high High priority

Comments

@jarbesfeld
Copy link
Contributor

Feature description

We should require the user to indicate whether the genomic coordinate they are supplying is from GRCh37 or GRCh38

Use case

We do not want to accidentally liftover a coordinate that is already in GRCh38. By having the user specify this, we can avoid this occurrence.

Proposed solution

Add an assembly parameter to genomic_to_tx_segment

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

Yes, I can create a PR for this feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarbesfeld jarbesfeld

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
1 participant
@jarbesfeld