From da18cf208b1f6b57f0fe1f4925c482b732ba8368 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Sun, 27 Jul 2025 12:20:51 +0800 Subject: [PATCH 1/2] No need to update check-links.yaml --- .github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md b/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md index 1ca5117ff5f..df1ff0fa57c 100644 --- a/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md +++ b/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md @@ -27,7 +27,6 @@ using the following command: - [ ] Update `.github/workflows/ci_tests.yaml` - [ ] Add the legacy GMT version to `.github/workflows/ci_tests_legacy.yaml` - [ ] Update GMT 6.x minor version for `extlinks` urls in `doc/conf.py` - - [ ] Update GMT 6.x minor version in `.github/workflows/check-links.yml` - [ ] Fix failing tests (1 or more PRs) - [ ] Fix failing doctests reported in the ["Doctest" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/ci_doctests.yaml) - [ ] Fix [xfail](https://docs.pytest.org/en/stable/skipping.html#xfail-mark-test-functions-as-expected-to-fail) pytest markers on tests that are now xpass From fc3005042214bf1b7ffd5d6023279f7515dbf4b9 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Tue, 30 Sep 2025 08:50:57 +0800 Subject: [PATCH 2/2] No need to update test_get_default --- .github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md b/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md index df1ff0fa57c..3a764669021 100644 --- a/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md +++ b/.github/ISSUE_TEMPLATE/5-bump_gmt_checklist.md @@ -35,8 +35,7 @@ using the following command: - [ ] Bump the minimum required GMT version (1 PR) - [ ] Update `required_gmt_version` in `pygmt/clib/__init__.py` - - [ ] Update `test_get_default` in `pygmt/tests/test_clib.py` - - [ ] Update minimum required versions in `doc/minversions.md` - [ ] Remove unsupported GMT version from `.github/workflows/ci_tests_legacy.yaml` + - [ ] Ensure minimum required version is correct in `doc/minversions.md` - [ ] Remove [xfail](https://docs.pytest.org/en/stable/skipping.html#xfail-mark-test-functions-as-expected-to-fail) pytest markers on tests that are now xpass - [ ] Update deprecated syntax in source code and examples based on the [GMT Changelog](https://docs.generic-mapping-tools.org/latest/changes.html)