Enable ruff's flake8-bugbear (B) rules (#2825)

Co-authored-by: Wei Ji <[email protected]>

Author: seisman

examples/gallery/images/rgb_image.py

@@ -28,7 +28,7 @@
     # Subset to area of Lāhainā in EPSG:32604 coordinates
     image = img.rio.clip_box(minx=738000, maxx=755000, miny=2300000, maxy=2318000)
     image = image.load()  # Force loading the DataArray into memory
-image
+image  # noqa: B018
 
 # %%
 # Plot the RGB imagery:

pygmt/clib/conversion.py

@@ -103,7 +103,7 @@ def dataarray_to_matrix(grid):
                 "but GMT only supports regular spacing. Calculated regular spacing "
                 f"{coord_inc} is assumed in the '{dim}' dimension."
             )
-            warnings.warn(msg, category=RuntimeWarning)
+            warnings.warn(msg, category=RuntimeWarning, stacklevel=2)
         if coord_inc == 0:
             raise GMTInvalidInput(
                 f"Grid has a zero increment in the '{dim}' dimension."

pygmt/clib/session.py

@@ -348,7 +348,7 @@ def create(self, name):
         """
         try:
             # Won't raise an exception if there is a currently open session
-            self.session_pointer
+            _ = self.session_pointer
             # In this case, fail to create a new session until the old one is
             # destroyed
             raise GMTCLibError(

pygmt/tests/test_clib.py

@@ -56,11 +56,11 @@ def mock_get_libgmt_func(name, argtypes=None, restype=None):
             return mock_func
         return get_libgmt_func(name, argtypes, restype)
 
-    setattr(session, "get_libgmt_func", mock_get_libgmt_func)
+    session.get_libgmt_func = mock_get_libgmt_func
 
     yield
 
-    setattr(session, "get_libgmt_func", get_libgmt_func)
+    session.get_libgmt_func = get_libgmt_func
 
 
 def test_getitem():
@@ -94,12 +94,12 @@ def test_create_destroy_session():
     ses = clib.Session()
     for __ in range(2):
         with pytest.raises(GMTCLibNoSessionError):
-            ses.session_pointer
+            _ = ses.session_pointer
         ses.create("session1")
         assert ses.session_pointer is not None
         ses.destroy()
         with pytest.raises(GMTCLibNoSessionError):
-            ses.session_pointer
+            _ = ses.session_pointer
 
 
 def test_create_session_fails():
@@ -183,7 +183,7 @@ def test_method_no_session():
     with pytest.raises(GMTCLibNoSessionError):
         lib.call_module("gmtdefaults", "")
     with pytest.raises(GMTCLibNoSessionError):
-        lib.session_pointer
+        _ = lib.session_pointer
 
 
 def test_parse_constant_single():

pyproject.toml

@@ -95,6 +95,7 @@ line-ending = "lf"  # Use UNIX `\n` line endings for all files
 
 [tool.ruff.lint]
 select = [
+    "B",    # flake8-bugbear
     "E",    # pycodestyle
     "F",    # pyflakes
     "I",    # isort