Fixed incorrect error for characters that do not exist

Author: Galarzaa90

.run/Unittests.run.xml

@@ -3,16 +3,16 @@
     <module name="tibia.py" />
     <option name="INTERPRETER_OPTIONS" value="" />
     <option name="PARENT_ENVS" value="true" />
-    <option name="SDK_HOME" value="$PROJECT_DIR$/venv/bin/python" />
-    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$" />
-    <option name="IS_MODULE_SDK" value="false" />
+    <option name="SDK_HOME" value="" />
+    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/tests" />
+    <option name="IS_MODULE_SDK" value="true" />
     <option name="ADD_CONTENT_ROOTS" value="true" />
     <option name="ADD_SOURCE_ROOTS" value="true" />
     <EXTENSION ID="PythonCoverageRunConfigurationExtension" runner="coverage.py" />
     <option name="_new_pattern" value="&quot;&quot;" />
     <option name="_new_additionalArguments" value="&quot;&quot;" />
-    <option name="_new_target" value="&quot;tibiapy&quot;" />
-    <option name="_new_targetType" value="&quot;CUSTOM&quot;" />
+    <option name="_new_target" value="&quot;$PROJECT_DIR$/tests&quot;" />
+    <option name="_new_targetType" value="&quot;PATH&quot;" />
     <method v="2" />
   </configuration>
 </component>

CHANGELOG.rst

@@ -6,6 +6,13 @@ Changelog
     Due to this library relying on external content, older versions are not guaranteed to work.
     Try to always use the latest version.
 
+.. v4.1.5
+
+4.1.5 (2021-06-25)
+==================
+- Fixed parsing bug on characters, returning an incorrect exception when a character doesn't exist.
+
+
 .. v4.1.4
 
 4.1.4 (2021-06-17)

tests/resources/character/tibiacom_not_found.txt

@@ -1,15 +1,3 @@
-<div class="BoxContent" style="background-image:url(https://ssl-static-tibia.akamaized.net/images/global/content/scroll.gif);">
-  <TABLE WIDTH=100% BORDER=0 CELLSPACING=1 CELLPADDING=4>
-  <TR><TD BGCOLOR="#505050" CLASS=white><B>Could not find character</B></TD></TR>
-  <TR><TD BGCOLOR="#D4C0A1"><TABLE BORDER=0 CELLPADDING=1><TR><TD>Character <b>afasfagf</b> does not exist.</TD></TR></TABLE></TD></TR>
-  </TABLE>
-  <br /><br />  <FORM ACTION="https://www.tibia.com/community/?subtopic=characters" METHOD=post>
-  <TABLE WIDTH=100% BORDER=0 CELLSPACING=1 CELLPADDING=4>
-  <TR><TD BGCOLOR="#505050" CLASS=white><B>Search Character</B></TD></TR>
-  <TR><TD BGCOLOR="#D4C0A1"><TABLE BORDER=0 CELLPADDING=1><TR>
-  <TD>Name:</TD><TD><INPUT NAME="name" VALUE="afasfagf"SIZE=29 MAXLENGTH=29></TD>
-  <TD><INPUT TYPE=image NAME="Submit" SRC="https://ssl-static-tibia.akamaized.net/images/global/buttons/sbutton_submit.gif" BORDER=0 WIDTH=120 HEIGHT=18></TD>
-  </TR></TABLE></TD></TR>
-  </TABLE>
-  </FORM>
-          </div>
+<div class="BoxContent" style="background-image:url(https://static.tibia.com/images/global/content/scroll.gif);">
+<div class="TableContainer"> <table class="Table1" cellpadding="0" cellspacing="0"> <div class="CaptionContainer"> <div class="CaptionInnerContainer"> <span class="CaptionEdgeLeftTop" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionEdgeRightTop" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionBorderTop" style="background-image:url(https://static.tibia.com/images/global/content/table-headline-border.gif);"></span> <span class="CaptionVerticalLeft" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-vertical.gif);" /></span> <div class="Text">Could not find character</div> <span class="CaptionVerticalRight" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-vertical.gif);" /></span> <span class="CaptionBorderBottom" style="background-image:url(https://static.tibia.com/images/global/content/table-headline-border.gif);"></span> <span class="CaptionEdgeLeftBottom" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionEdgeRightBottom" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> </div> </div> <tr> <td> <div class="InnerTableContainer"> <table style="width:100%;"><tr><td>Character <b>critosio</b> does not exist.</td></tr> </table> </div> </td> </tr> </table></div><br /><br /><form><div class="TableContainer"> <table class="Table1" cellpadding="0" cellspacing="0"> <div class="CaptionContainer"> <div class="CaptionInnerContainer"> <span class="CaptionEdgeLeftTop" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionEdgeRightTop" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionBorderTop" style="background-image:url(https://static.tibia.com/images/global/content/table-headline-border.gif);"></span> <span class="CaptionVerticalLeft" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-vertical.gif);" /></span> <div class="Text">Search Character</div> <span class="CaptionVerticalRight" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-vertical.gif);" /></span> <span class="CaptionBorderBottom" style="background-image:url(https://static.tibia.com/images/global/content/table-headline-border.gif);"></span> <span class="CaptionEdgeLeftBottom" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> <span class="CaptionEdgeRightBottom" style="background-image:url(https://static.tibia.com/images/global/content/box-frame-edge.gif);" /></span> </div> </div> <tr> <td> <div class="InnerTableContainer"> <table style="width:100%;"><tr><td style="vertical-align:middle;" class="LabelV150">Character Name:</td><td style="width:170px;"><input style="width:165px;" name="name" value="critosio" size="29" maxlength="29" /></td><td><div class="BigButton" style="background-image:url(https://static.tibia.com/images/global/buttons/button_blue.gif)"><div onMouseOver="MouseOverBigButton(this);" onMouseOut="MouseOutBigButton(this);"><div class="BigButtonOver" style="background-image:url(https://static.tibia.com/images/global/buttons/button_blue_over.gif);"></div><input class="BigButtonText" type="submit" value="Submit" /></div></div></td></tr> </table> </div> </td> </tr> </table></div></form> </div>
+</div>

tibiapy/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '4.1.4'
+__version__ = '4.1.5'
 __author__ = 'Allan Galarza'
 
 import logging

tibiapy/character.py

@@ -309,8 +309,10 @@ def from_content(cls, content):
         parsed_content = parse_tibiacom_content(content)
         tables = cls._parse_tables(parsed_content)
         char = Character()
-        if "Could not find character" in tables.keys():
-            return None
+        if not tables:
+            messsage_table = parsed_content.find("div", {"class": "TableContainer"})
+            if messsage_table and "Could not find character" in messsage_table.text:
+                return None
         if "Character Information" in tables.keys():
             char._parse_character_information(tables["Character Information"])
         else: