Added some missing test cases

Author: Galarzaa90

tests/tests_client.py

@@ -4,8 +4,9 @@
 import asynctest
 from aioresponses import aioresponses
 
-from tests.tests_bazaar import FILE_BAZAAR_CURRENT
+from tests.tests_bazaar import FILE_BAZAAR_CURRENT, FILE_BAZAAR_HISTORY, FILE_AUCTION_FINISHED
 from tests.tests_character import FILE_CHARACTER_RESOURCE, FILE_CHARACTER_NOT_FOUND
+from tests.tests_events import FILE_EVENT_CALENDAR
 from tests.tests_forums import FILE_CM_POST_ARCHIVE_PAGES
 from tests.tests_guild import FILE_GUILD_FULL, FILE_GUILD_LIST
 from tests.tests_highscores import FILE_HIGHSCORES_FULL
@@ -17,7 +18,8 @@
 from tibiapy import CharacterBazaar, Client, Character, CMPostArchive, Guild, Highscores, VocationFilter, Category, \
     House, ListedHouse, \
     ListedGuild, \
-    KillStatistics, ListedNews, News, World, WorldOverview, Forbidden, NetworkError, Creature
+    KillStatistics, ListedNews, News, World, WorldOverview, Forbidden, NetworkError, Creature, AuctionDetails, \
+    EventSchedule
 
 
 class TestClient(asynctest.TestCase, TestCommons):
@@ -229,4 +231,46 @@ async def test_client_fetch_current_auctions(self, mock):
         response = await self.client.fetch_current_auctions()
         self.assertIsInstance(response.data, CharacterBazaar)
 
+    async def test_client_fetch_current_auctions_invalid_page(self):
+        """Testing fetching the current auctions with an invalid page"""
+        with self.assertRaises(ValueError):
+            await self.client.fetch_current_auctions(-1)
+
+    @aioresponses()
+    async def test_client_fetch_auction_history(self, mock):
+        """Testing fetching the auction history"""
+        content = self.load_resource(FILE_BAZAAR_HISTORY)
+        mock.get(CharacterBazaar.get_auctions_history_url(), status=200, body=content)
+        response = await self.client.fetch_auction_history()
+        self.assertIsInstance(response.data, CharacterBazaar)
+
+    async def test_client_fetch_auction_history_invalid_page(self):
+        """Testing fetching the auction history with an incorrect page"""
+        with self.assertRaises(ValueError):
+            await self.client.fetch_auction_history(-1)
 
+    @aioresponses()
+    async def test_client_fetch_auction(self, mock):
+        """Testing fetching an auction"""
+        content = self.load_resource(FILE_AUCTION_FINISHED)
+        mock.get(AuctionDetails.get_url(134), status=200, body=content)
+        response = await self.client.fetch_auction(134)
+        self.assertIsInstance(response.data, AuctionDetails)
+
+    async def test_client_fetch_auction_invalid_id(self):
+        """Testing fetching an auction with an invalid id"""
+        with self.assertRaises(ValueError):
+            await self.client.fetch_auction(-1)
+
+    @aioresponses()
+    async def test_client_fetch_event_calendar(self, mock):
+        """Testing fetching the auction history"""
+        content = self.load_resource(FILE_EVENT_CALENDAR)
+        mock.get(EventSchedule.get_url(), status=200, body=content)
+        response = await self.client.fetch_event_schedule()
+        self.assertIsInstance(response.data, EventSchedule)
+
+    async def test_client_fetch_event_calendar_invalid_params(self):
+        """Testing fetching the auction history"""
+        with self.assertRaises(ValueError):
+            await self.client.fetch_event_schedule(3)

tests/tests_creature.py

@@ -44,5 +44,10 @@ def test_creature_detail_from_content(self):
         self.assertIsNotNone(creature)
         self.assertEqual("Animated Feathers", creature.name)
         self.assertEqual("animatedfeather", creature.race)
+        self.assertEqual(13000, creature.hitpoints)
+        self.assertEqual(9860, creature.experience)
+        self.assertIsNone(creature.mana_cost)
+        self.assertFalse(creature.summonable)
+        self.assertFalse(creature.convinceable)
         self.assertIsNotNone(creature.description)
     # endregion

tibiapy/client.py

@@ -228,7 +228,7 @@ async def fetch_current_auctions(self, page=1, filters=None):
         ValueError
             If the page number is not 1 or greater.
         """
-        if not page:
+        if page <= 0:
             raise ValueError('page must be 1 or greater.')
         response = await self._request("GET", CharacterBazaar.get_current_auctions_url(page, filters))
         start_time = time.perf_counter()
@@ -261,7 +261,7 @@ async def fetch_auction_history(self, page=1):
         ValueError
             If the page number is not 1 or greater.
         """
-        if not page:
+        if page <= 0:
             raise ValueError('page must be 1 or greater.')
         response = await self._request("GET", CharacterBazaar.get_auctions_history_url(page))
         start_time = time.perf_counter()
@@ -303,7 +303,11 @@ async def fetch_auction(self, auction_id, *, fetch_items=False, fetch_mounts=Fal
             This usually means that Tibia.com is rate-limiting the client because of too many requests.
         NetworkError
             If there's any connection errors during the request.
+        ValueError
+            If the auction id is not 1 or greater.
         """
+        if auction_id <= 0:
+            raise ValueError('auction_id must be 1 or greater.')
         response = await self._request("GET", AuctionDetails.get_url(auction_id))
         start_time = time.perf_counter()
         auction = AuctionDetails.from_content(response.content, auction_id, skip_details)
@@ -321,7 +325,7 @@ async def fetch_auction(self, auction_id, *, fetch_items=False, fetch_mounts=Fal
         return TibiaResponse(response, auction, parsing_time)
 
     async def _fetch_all_pages(self, auction_id, paginator, item_type):
-        """Fetches all the pages of a auction paginator.
+        """Fetches all the pages of an auction paginator.
 
         Parameters
         ----------
@@ -411,7 +415,7 @@ async def fetch_cm_post_archive(self, start_date, end_date, page=1):
         return TibiaResponse(response, cm_post_archive, parsing_time)
 
     async def fetch_event_schedule(self, month=None, year=None):
-        """Fetches the event calendar.
+        """Fetches the event calendar. By default, it gets the events for the current month.
 
         .. versionadded:: 3.0.0
 
@@ -434,6 +438,8 @@ async def fetch_event_schedule(self, month=None, year=None):
             This usually means that Tibia.com is rate-limiting the client because of too many requests.
         NetworkError
             If there's any connection errors during the request.
+        ValueError
+            If only one of year or month are defined.
         """
         if (year is None and month is not None) or (year is not None and month is None):
             raise ValueError("both year and month must be defined or neither must be defined.")

tibiapy/creature.py

@@ -254,7 +254,7 @@ def from_content(cls, content):
 
         Returns
         -------
-        :class:`Character`
+        :class:`CreatureDetail`
             The character contained in the page.
         """
         try: