Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtle depends on a deprecated library, system-filepath. #254

Open
crocket opened this issue Aug 22, 2017 · 6 comments
Open

turtle depends on a deprecated library, system-filepath. #254

crocket opened this issue Aug 22, 2017 · 6 comments

Comments

@crocket
Copy link

crocket commented Aug 22, 2017

I tried to replace optparse-applicative with Turtle.Options which is simpler.
However, its dependence on system-filepath deterred me from adoption.

@3noch
Copy link

3noch commented Aug 22, 2017

That particular deprecation is highly contested.

@Gabriella439
Copy link
Owner

The main reason that turtle uses system-filepath is that it's the only path library that:

  • treats paths as a new type and not a synonym for String/ByteString
  • has an IsString instance for paths

However, perhaps I should just take ownership of system-filepath so that it can no longer be deprecated. Would that resolve your issue?

@crocket
Copy link
Author

crocket commented Aug 22, 2017

I think it would.

@3noch
Copy link

3noch commented Aug 23, 2017

@Gabriel439 Just to put it on the table: path is now my favorite library for dealing with paths. The IsString instance is missing (for good reason), but I could see an argument for turtle adding an orphan instance for a polymorphic Path given that turtle is for scripting.

That said, I can also understand reasons against using it (bad support for relative paths, more types, etc.). I would welcome an un-deprecation of system-filepath.

@vmchale
Copy link
Contributor

vmchale commented Dec 5, 2018

Unfortunately, system-filepath breaks cross-compilation due to using build-type: Custom, which means bench is broken by transitivity.

(I have no interest in what solution is picked so long as that is resolved :))

@crocket
Copy link
Author

crocket commented Dec 25, 2018

You could replace system-filepath with http://hackage.haskell.org/package/path
There's also path-io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants